alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

In D132998#3762578 <https://reviews.llvm.org/D132998#3762578>, 
@alexander-shaposhnikov wrote:

> Regarding the practical side - yeah, I've come across this issue (and others) 
> while trying to run this check over a few large codebases (including Chrome 
> and LLVM),
> and this particular issue accounts for a few hundreds of build breakages.

Then I would be in favor of this change. The only downside I see is that it 
will require first ensuring the project compiles in C++11 or later. This 
doesn't look like a major inconvenience to me (unlike modernize-use-nullptr, 
for example).

Looks good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132998/new/

https://reviews.llvm.org/D132998

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to