Eugene.Zelenko added inline comments.

================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1
-// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- 
-fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- 
-config="{CheckOptions: [{key: 
readability-container-data-pointer.IgnoredContainers, value: '::arrayType'}]}" 
-- -fno-delayed-template-parsing
 
----------------
felix642 wrote:
> Eugene.Zelenko wrote:
> > I think test should be separated to handle situations with and without 
> > option.
> Hi @Eugene.Zelenko, 
> 
> I'm not familiar with clang-tidy's testing environment. What do you mean 
> precisely by "test should be separated"? Does it mean I should define this 
> test in a different .cpp with the appropriate tests?  
I meant that dedicated test for new check option should be created. But will be 
good idea to expand original one, so difference in behavior could be observed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133244/new/

https://reviews.llvm.org/D133244

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D133244:... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D13... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D13... Eugene Zelenko via Phabricator via cfe-commits
    • [PATCH] D13... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D13... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D13... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D13... Félix-Antoine Constantin via Phabricator via cfe-commits

Reply via email to