Jim added inline comments.
================ Comment at: clang/include/clang/Basic/riscv_vector.td:2833 } + let Name = "vcreate_v", + UnMaskedPolicyScheme = NonePolicy, ---------------- Can we add a blank line before this. ================ Comment at: clang/include/clang/Basic/riscv_vector.td:2848 + }] in { + // foreach type = TypeList in { + foreach nf = NFList in { ---------------- Does this forget to be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158402/new/ https://reviews.llvm.org/D158402 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits