https://github.com/MaskRay requested changes to this pull request.
Using unique_ptr for `Args` is good, but I am not sure about shared_ptr for TranslatedArgs. There is no shared_ptr usage in clangDriver and we want to keep avoiding it. https://github.com/llvm/llvm-project/pull/116406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits