efriedma-quic wrote: The function in question is part of the Itanium C++ ABI; the ABI itself doesn't say anything about address-spaces, so by default we assume everything related to the C++ ABI is in the flat address-space. If we start messing with that, we'll need to write a specification somewhere to document exactly which functions use which address-spaces.
So I think casting here is appropriate; we can revisit if someone ever wants to define a "GPU Itanium ABI" with different address-spaces. The change to ItaniumCXXABI.cpp looks fine (please address the review comments on the regression test). https://github.com/llvm/llvm-project/pull/119246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
