================
@@ -238,6 +239,7 @@ std::unique_ptr<ASTUnit> buildASTFromCodeWithArgs(
     ArgumentsAdjuster Adjuster = getClangStripDependencyFileAdjuster(),
     const FileContentMappings &VirtualMappedFiles = FileContentMappings(),
     DiagnosticConsumer *DiagConsumer = nullptr,
+    CaptureDiagsKind CaptureKind = CaptureDiagsKind::None,
----------------
HighCommander4 wrote:

This is a public API, and likely one with a fair number of downstream users.

While clang doesn't make any stability guarantees about it's C++ API, I think 
it's still good practice to avoid API breaks that are unnecessary, since it 
takes work for downstreams to rebase across them.

So, in a case like this, where we're adding a new optional argument to an API 
function, I think we should add it to the end.

https://github.com/llvm/llvm-project/pull/155561
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to