================
@@ -4197,6 +4197,54 @@ class RenameMSVCLibmFuncs
 };
 } // namespace
 
+namespace {
+/// convert value between fir type and core mlir type.
+struct UnrealizedConversionCastOpConversion
----------------
NexMing wrote:

> It might be better to create an other codegen pass with your change since 
> this is experimental. You can use `fir::populateFIRToLLVMConversionPatterns` 
> to get the conversion patterns from this pass. Also I don't see any test for 
> the codegen part so it might be better to do this in another PR.

Thank you for the suggestion. I think I’ll try this in another PR.

https://github.com/llvm/llvm-project/pull/168703
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to