ChuanqiXu9 wrote: > > Yeah, if you already have this, why do you think it is burden to implement > > `noload_redecls()`? You've already reached it! > > Because it's a local implementation that works in `ASTReader`. I don't want > to think about the more general picture of a function that is usable in all > of Clang (that will need rounds of review), nor fight with C++ iterators.
But `getPreviousDecl` may trigger deserialization too. Please look at `getPrevious()` in `Redeclarable::DeclLink::getPrevious`. I don't feel it is hard or you need to fight any thing. We already have `getLatestNotUpdated()` and we can implement `getPreviousNotUpdated()` similarly, then we're almost done. If we're tired of invalid iterations, we can use `make_early_inc_range`. HDYT? The patch have already been stalled by 8 months. I feel all of us are patient enough. https://github.com/llvm/llvm-project/pull/133057 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
