https://github.com/jansvoboda11 commented:
This makes sense conceptually, but I'd like to see more prep commits so that this one is easier to review. I commented on what I think could be extracted out of this PR. I'll defer the full review to @qiongsiwu, who I believe had reasons to put some functions to the header file while you move them to the implementation file (`initVFSForTUBufferScanning` for example). https://github.com/llvm/llvm-project/pull/169964 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
