[clang-tools-extra] [clang-tidy][NFC] Enable `bugprone-unchecked-optional-access` in `clang-tidy` config and fix warnings (PR #170004)

[Baranov Victor via cfe-commits]

================
@@ -1344,10 +1346,14 @@ IdentifierNamingCheck::getFailureInfo(
     ArrayRef<std::optional<IdentifierNamingCheck::NamingStyle>> NamingStyles,
     const IdentifierNamingCheck::HungarianNotationOption &HNOption,
     StyleKind SK, const SourceManager &SM, bool IgnoreFailedSplit) const {
-  if (SK == SK_Invalid || !NamingStyles[SK])
+  if (SK == SK_Invalid)
     return std::nullopt;
 
-  const IdentifierNamingCheck::NamingStyle &Style = *NamingStyles[SK];
----------------
vbvictor wrote:

So dataflow couldn't handle checking for multiple optional values in one go? 
Seems like FP.

https://github.com/llvm/llvm-project/pull/170004
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits