YuriPlyakhin wrote: > Basically, what I'm hoping here is that we just have the minimal changes to > support the multiple entries. The interface should look like this, I don't > think we need to change much of anything if we're smart about it. > > Data -> binary array -> binary binary -> array // All share a reference to > `binary` copy(OffloadFile) -> copies the header in the shared buffer. > > We will need to create single offload files when making the array, these > should likely just use an index as an optional argument to the current > interface.
I'm sorry, it is a bit ambiguous. Could you please clarify what exactly do you mean by: - `Data` (is it `Buffer`?), - `binary` (is it `OffloadBinary`?) - array (is it array of `Entry` structs?) - `copies the header in the shared buffer` (what do you mean exactly by shared buffer in context of `OffloadFile` object?) https://github.com/llvm/llvm-project/pull/169425 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
