yxsamliu wrote:
A few suggestions, all non-blocking:
**Docs and release note**
- Could you add a short release note in `clang/docs/ReleaseNotes.rst` (Windows
/ driver section) mentioning that the MSVC toolchain now honors
`--multi-lib-config=` and `-fmultilib-flag=`? It's a user-visible feature and
the ROCm-on-Windows motivation is worth a one-liner.
- `clang/docs/Multilib.rst` lists this as EXPERIMENTAL with per-ToolChain
opt-in ("once support for it is added in relevant ToolChain classes"). Since
this PR opts MSVC in, it'd be nice to mention MSVC in the supported-toolchain
list there. Also, step 5 of *Multilib processing* says Clang generates both
`-isystem` and `-L` for matching variants, but this PR only adds `-isystem` —
either add the `-L` half too, or note in the doc that MSVC is include-only for
now.
**Test coverage**
- The Multilib doc points users to `-print-multi-flags-experimental` for
debugging multilib selection. Could you add a small MSVC RUN line to
`clang/test/Driver/print-multi-selection-flags.c` (which already covers
aarch64-linux / fuchsia / arm-none-eabi)? That keeps flag-normalization
coverage close to its siblings and guards against MSVC-specific regressions.
https://github.com/llvm/llvm-project/pull/200212
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
