evelez7 wrote:

It's pretty hard to review code like this since this contains all the changes 
present in the other PR, so we can't distinguish the diffs since they're both 
against main. Technically this isn't stacked on #200302 since it's not being 
compared against that branch.

LLVM has a couple ways to do stacked PRs. There's spr (which I never used 
thanks to Paul's warnings) and 
[Graphite](https://llvm.org/docs/GitHub.html#using-graphite-for-stacked-pull-requests).
 If you want to keep your work compartmentalized I suggest learning it. It's 
pretty helpful.

You could also just compare this branch against your first one but I don't 
think that scales well.

https://github.com/llvm/llvm-project/pull/201746
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to