Works great for me. Thanks! On Friday, January 24, 2014 3:18:48 PM UTC+1, Chas Emerick wrote: > On Thu 23 Jan 2014 09:29:52 PM EST, Chas Emerick wrote: > > > > > > On 01/23/2014 08:19 PM, Michael Glaesemann wrote: > > >> On Jan 23, 2014, at 10:16, Chas Emerick wrote: > > >> > > >>> Nice, thanks for digging in! > > >>> > > >>> It looks like you're not yet accommodating arbitrary JS expressions, > > >>> which can appear in the test command vector; this is documented here: > > >>> > > >>> https://github.com/cemerick/clojurescript.test#configuring-tests-via-javascript-filesexpressions-in-test-commands > > >>> > > >>> > > >>> Once you have that put together, I'd be very happy to see a PR. If > > >>> you could place the runner as a sibling of the existing runner.js > > >>> script, that'd be great. For extra credit, you could modify the > > >>> clojurescript.test project middleware to (a) dump the node runner to > > >>> its own temp file, and (b) swap > > >>> s/:node-runner/"$PATH_TO_NODE_RUNNER" in the project map to match > > >>> what's being done for the phantomjs :runner placeholder. > > >> Here you go :) > > >> > > >> https://github.com/cemerick/clojurescript.test/pull/38 > > >> > > >> The updates to middleware are more procedural than I'd like, but I > > >> wasn't sure how you'd want to handle it. > > >> > > >> https://github.com/grzm/clojurescript.test/commit/2e46024e1e1d3501caa12a8c44c5bbd8806e0451 > > >> > > >> > > >> Let me know if you'd like any changes. > > >> > > >> Cheers! > > >> > > >> Michael Glaesemann > > >> grzm seespotcode net > > >> > > > > > > Looks good after a quick skim! Yeah, the middleware could be a little > > > tighter, but replicating what's there already is fine for now. > > > Anyway, I'll take a closer look and likely merge in a little bit. > > > > > > I'm in the middle of working on adding async support, but I think I > > > might slip out a release with the node runner first, since the async > > > stuff is probably going to bake in a snapshot for a while. I'll post > > > a message on this thread when the release goes out. > > > > > > Thanks! > > > > > > - Chas > > > > > > > For anyone following along, I've merged Michael's patch (thanks again! > > :-D), and "released" a SNAPSHOT build of clojurescript.test that > > includes the node.js test runner. Use version "0.2.2-SNAPSHOT" to get > > it. > > > > Please give it a shot if you're interested (see > > https://github.com/cemerick/clojurescript.test/tree/develop/0.2.0 for > > info on how to configure your project to use node instead of > > phantomjs), and report any problems you see via github or to me on > > twitter. > > > > Cheers, > > > > - Chas
-- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
