On Jun 18, 2010, at 15:15, Jonny Taylor wrote: >> [theImage release] is really suspicious. > Suspicious in what way? Are you saying I am using the wrong sort of > implementation for my [frame GetNSImage], and I shouldn't be returning > something that requires an explicit release? Because I can certainly confirm > that in its current state it leaks memory unless I include the release - the > function is returning an internally cached NSImage with its reference count > incremented by one. > > To be fair the release is in an illogical place - it should immediately > follow the call to [theImage TIFFRepresentation], but with the code as > currently written, the release is definitely > necessary..._______________________________________________
Usually, you don't release objects you don't own. In the block you showed, there really is no indication that you own theImage (there is no alloc/init, copy or retain) so you shouldn't release it, unless I'm missing something with blocks. -Laurent. -- Laurent Daudelin AIM/iChat/Skype:LaurentDaudelin http://www.nemesys-soft.com/ Logiciels Nemesys Software laur...@nemesys-soft.com _______________________________________________ Cocoa-dev mailing list (Cocoa-dev@lists.apple.com) Please do not post admin requests or moderator comments to the list. Contact the moderators at cocoa-dev-admins(at)lists.apple.com Help/Unsubscribe/Update your Subscription: http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com This email sent to arch...@mail-archive.com
