[ https://issues.apache.org/jira/browse/AIRFLOW-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759005#comment-16759005 ]
ASF subversion and git services commented on AIRFLOW-3602: ---------------------------------------------------------- Commit b07ed8651f7fd81da5b9d357717b124672693cd4 in airflow's branch refs/heads/v1-10-test from Felix [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b07ed86 ] [AIRFLOW-3602] Improve ImapHook handling of retrieving no attachments (#4475) > Change ImapHook to raise an Exception when no attachments have been found > ------------------------------------------------------------------------- > > Key: AIRFLOW-3602 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3602 > Project: Apache Airflow > Issue Type: Improvement > Affects Versions: 1.10.1 > Reporter: Felix Uellendall > Assignee: Felix Uellendall > Priority: Major > Fix For: 2.0.0, 1.10.3 > > > At the moment the > {code:python} > def retrieve_mail_attachments(self, name, mail_folder='INBOX', > check_regex=False, > latest_only=False): > {code} > returns an empty list if no attachments have been found. > And the > {code:python} > def download_mail_attachments(self, name, local_output_directory, > mail_folder='INBOX', > check_regex=False, latest_only=False): > {code} > also does not log anything if no attachment has been found. > Is this useful? Or would it be better to raise an exception instead? -- This message was sent by Atlassian JIRA (v7.6.3#76005)