ashb commented on a change in pull request #4910: [AIRFLOW-2190] Send correct
HTTP status for base_url not found
URL: https://github.com/apache/airflow/pull/4910#discussion_r265222747
##########
File path: airflow/bin/cli.py
##########
@@ -884,13 +884,13 @@ def webserver(args):
print(
"Starting the web server on port {0} and host {1}.".format(
args.port, args.hostname))
- app, _ = create_app(conf, testing=conf.get('core', 'unit_test_mode'))
+ app, _ = create_app(None, testing=conf.get('core', 'unit_test_mode'))
Review comment:
Previously the `config` argument to create_app wasn't used by that app, but
in tidying up of the tests I started using it -- it is now a dict that is
merged in to the flask `app.config`.
https://github.com/apache/airflow/pull/4910/files#diff-3d86925e55c01b3d8f3cb10def92fd1cR62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
