kaxil commented on a change in pull request #5054: [AIRFLOW-4255] Replace
Discovery based api with client based for GCS
URL: https://github.com/apache/airflow/pull/5054#discussion_r272865859
##########
File path: airflow/contrib/hooks/gcs_hook.py
##########
@@ -47,9 +45,11 @@ def get_conn(self):
"""
Returns a Google Cloud Storage service object.
"""
- http_authorized = self._authorize()
- return build(
- 'storage', 'v1', http=http_authorized, cache_discovery=False)
+ if not self._conn:
+ self._conn = storage.Client(credentials=self._get_credentials(),
+ project=self.project_id)
Review comment:
Ya, let's discuss this and decide on this on the mailing list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
