ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r299366677
##########
File path: hooks/build
##########
@@ -345,7 +398,12 @@ if [[ "${OSTYPE}" == "darwin"* ]]; then
fi
# Build id identifying the build uniquely
BUILD_ID=${BUILD_ID:="local"}
-# Branch name for triggered builds
+# Branch name to build
+# Define an empty BRANCH_NAME_FIRST
+BRANCH_NAME=${BRANCH_NAME:=""}
+# in case SOURCE_BRANCH is defined it can override the BRANCH_NAME
+BRANCH_NAME=${SOURCE_BRANCH:=${BRANCH_NAME}}
+# Default branch name for triggered builds is master
BRANCH_NAME=${BRANCH_NAME:="master"}
Review comment:
Are the previous 3 statments the same as this?
```bash
BRANCH_NAME=${SOURCE_BRANCH:-"master"}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
