ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303056069
########## File path: scripts/ci/ci_mypy.sh ########## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +set -euo pipefail + +MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" +# shellcheck source=./_check_not_in_container.sh +. "${MY_DIR}/_check_not_in_container.sh" + +pushd "${MY_DIR}/../../" || exit 1 + +export AIRFLOW_CONTAINER_SKIP_SLIM_CI_IMAGE="false" +export AIRFLOW_CONTAINER_SKIP_CI_IMAGE="true" +export AIRFLOW_CONTAINER_PUSH_IMAGES="false" +export AIRFLOW_CONTAINER_BUILD_NPM="false" +export AIRFLOW_CONTAINER_CI_OPTIMISED_BUILD="true" + +# shellcheck source=../../hooks/build +. ./hooks/build + +set -x +docker run --entrypoint mypy "${AIRFLOW_SLIM_CI_IMAGE}" airflow tests +set +x + +popd || exit 1 Review comment: Not that it matters, but unless this file is `source`d then it doesn't matter what CWD the script finishes up in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
