potiuk commented on PR #30784: URL: https://github.com/apache/airflow/pull/30784#issuecomment-1519112616
I am afraid this change is not backwards-compatible with the old common.sql providers. We have to remember that we have potentially complex relation between SQL providers and common.sql - and one can have common.sql 1.0 and latest databricks for example. There are two ways of handling it: 1) make the change backwards compatible for each provider (it will complicate the code of each of them a bit and defeat the purpose of the change IMHO) 2) update all SQL providers to `common-sql >= 1.5.0` and set common.sql version to 1.5.0 for the next release (much better IMHO) BTW. This is the main reason why we want to make sure common.sql provider is 100% backwards compatible - for all the providers - because the moment we make common.sql == 2.0.0, it with some breaking chnages, it will mean that if one provider will start using features from 2.0 and require it, all the other providers will also need to be upgraded which might be undesireable and we loose the "you can upgrade/downgrde providers independently" property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
