jscheffl commented on code in PR #44744:
URL: https://github.com/apache/airflow/pull/44744#discussion_r1890792030


##########
scripts/ci/pre_commit/compile_www_assets.py:
##########
@@ -71,4 +72,20 @@ def get_directory_hash(directory: Path, skip_path_regexp: 
str | None = None) ->
     subprocess.check_call(["yarn", "install", "--frozen-lockfile"], 
cwd=os.fspath(www_directory))
     subprocess.check_call(["yarn", "run", "build"], 
cwd=os.fspath(www_directory), env=env)
     new_hash = get_directory_hash(www_directory, 
skip_path_regexp=r".*node_modules.*")
-    WWW_HASH_FILE.write_text(new_hash)
+    www_hash_file.write_text(new_hash)
+
+
+def is_fab_provider_installed() -> bool:
+    return importlib.util.find_spec("airflow.providers.fab") is not None

Review Comment:
   Ups, this change in this function broke main :-( 
   https://github.com/apache/airflow/actions/runs/12399970802/job/34616478712
   
   I assume we need to find another method to check if FAB is installed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to