MaksYermak commented on code in PR #45610:
URL: https://github.com/apache/airflow/pull/45610#discussion_r1914517397
##########
providers/src/airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1717,12 +1717,14 @@ def execute(self, context: Context) -> None:
"tableId": table_id,
},
"labels": self.labels,
- "schema": {"fields": schema_fields},
"externalDataConfiguration": external_data_configuration,
"location": self.location,
"encryptionConfiguration": self.encryption_configuration,
}
+ if self.schema_fields:
Review Comment:
Hello @EugeneYushin ,
I think your changes broke this part of the code
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/google/cloud/operators/bigquery.py#L1679C8-L1686C14
for me it looks like that the `schema_fields`, from this peace of code, will
never assign to `table_resource` if we merge your changes.
Also I think, maybe this code is a reason why `autodetect` does not work.
For me it looks like `schema_fields` is always present in the `table_resource`.
Could you please check and prove that case which cover by this code
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/google/cloud/operators/bigquery.py#L1679C8-L1686C14
is working with your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
