ferruzzi commented on code in PR #45704:
URL: https://github.com/apache/airflow/pull/45704#discussion_r1919068887
##########
providers/tests/system/amazon/aws/example_bedrock_retrieve_and_generate.py:
##########
@@ -442,9 +442,8 @@ def delete_opensearch_policies(collection_name: str):
test_context = sys_test_context_task()
env_id = test_context["ENV_ID"]
- aoss_client = OpenSearchServerlessHook(aws_conn_id=None)
- bedrock_agent_client = BedrockAgentHook(aws_conn_id=None)
-
+ aoss_client = OpenSearchServerlessHook()
+ bedrock_agent_client = BedrockAgentHook()
Review Comment:
> My guess is that @ferruzzi did the None thing to avoid some other failures
or copied the behaviour from unit tests - but yeah.
I don't remember doing it to get around other issues. I think maybe I added
it in there to avoid hitting the db but clearly that was the wrong answer. I
just did a quick check and we're not doing `=None` in any other system tests,
so as long as it's still passing (which Vincent already confirmed) it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
