jscheffl commented on code in PR #48118:
URL: https://github.com/apache/airflow/pull/48118#discussion_r2010859124


##########
.github/workflows/ci-image-checks.yml:
##########
@@ -377,16 +377,13 @@ jobs:
           rm /tmp/awscliv2.zip
           sudo /tmp/aws/install --update
           rm -rf /tmp/aws/
-        if: inputs.branch == 'main'
       - name: Configure AWS credentials
         uses: 
aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a  
# v4.0.1
-        if: inputs.branch == 'main'
         with:
           aws-access-key-id: ${{ secrets.DOCS_AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }}
           aws-region: eu-central-1
       - name: "Upload documentation to AWS S3"
-        if: inputs.branch == 'main'

Review Comment:
   Just saw this - do you think this is a good idea? This basically means that 
every pipeline run will publish docs to AWS?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to