This is an automated email from the ASF dual-hosted git repository.
damccorm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new c10028b2583 Fix UnusedVariable warnings across codebase (#37770)
c10028b2583 is described below
commit c10028b2583fe6977656fc0361b06def756b7e5f
Author: Radosław Stankiewicz <[email protected]>
AuthorDate: Fri Mar 20 18:25:59 2026 +0100
Fix UnusedVariable warnings across codebase (#37770)
supress warnings in tests
---
.../org/apache/beam/gradle/BeamModulePlugin.groovy | 1 -
...BoundedSplittableProcessElementInvokerTest.java | 8 +++---
.../SimplePushbackSideInputDoFnRunnerTest.java | 3 ++-
.../runners/core/SplittableParDoProcessFnTest.java | 17 +++++++-----
.../apache/beam/runners/direct/DirectMetrics.java | 4 ++-
...cycleManagerRemovingTransformEvaluatorTest.java | 2 +-
.../runners/direct/DoFnLifecycleManagerTest.java | 2 +-
.../runners/direct/DoFnLifecycleManagersTest.java | 4 +--
.../runners/flink/FlinkExecutionEnvironments.java | 2 --
.../streaming/ExecutableStageDoFnOperator.java | 4 +--
.../beam/runners/flink/ReadSourcePortableTest.java | 2 ++
.../dataflow/DataflowPipelineTranslatorTest.java | 6 +++--
.../dataflow/worker/StreamingDataflowWorker.java | 2 ++
.../dataflow/worker/status/DebugCapture.java | 2 ++
.../dataflow/worker/DefaultParDoFnFactoryTest.java | 2 +-
.../dataflow/worker/DoFnInstanceManagersTest.java | 3 ++-
.../worker/StreamingDataflowWorkerTest.java | 2 +-
.../dataflow/worker/WorkerCustomSourcesTest.java | 1 +
.../logging/DataflowWorkerLoggingHandlerTest.java | 1 +
.../PortablePipelineJarCreatorTest.java | 4 +--
.../translation/ParDoBoundMultiTranslator.java | 2 +-
.../apache/beam/sdk/schemas/transforms/Select.java | 7 +++--
.../apache/beam/sdk/coders/CoderRegistryTest.java | 4 +--
.../sdk/options/PipelineOptionsFactoryTest.java | 3 ++-
.../sdk/options/ProxyInvocationHandlerTest.java | 1 +
.../beam/sdk/schemas/utils/JsonUtilsTest.java | 2 ++
.../apache/beam/sdk/transforms/DoFnTesterTest.java | 2 +-
.../org/apache/beam/sdk/transforms/WaitTest.java | 2 +-
.../sdk/transforms/display/DisplayDataTest.java | 2 +-
.../sdk/transforms/reflect/DefaultPackageTest.java | 2 +-
.../reflect/DoFnSignaturesSplittableDoFnTest.java | 12 ++++++---
.../construction/PTransformReplacementsTest.java | 2 +-
.../construction/PTransformTranslationTest.java | 2 +-
.../util/construction/ParDoTranslationTest.java | 21 +++++++++------
.../util/construction/PipelineTranslationTest.java | 2 +-
.../sdk/util/construction/SplittableParDoTest.java | 12 ++++++---
.../construction/graph/FieldAccessVisitorTest.java | 7 ++---
.../graph/ProjectionProducerVisitorTest.java | 2 +-
.../graph/ProjectionPushdownOptimizerTest.java | 5 ++--
.../construction/graph/QueryablePipelineTest.java | 2 +-
.../sdk/expansion/service/ExpansionService.java | 2 +-
.../sdk/extensions/avro/coders/AvroCoderTest.java | 2 ++
.../beam/sdk/extensions/sql/impl/nfa/NFA.java | 31 +++-------------------
.../sql/impl/rel/BeamEnumerableConverter.java | 2 +-
.../sdk/extensions/sql/impl/rel/BeamWindowRel.java | 10 ++++---
.../sql/impl/rel/BeamEnumerableConverterTest.java | 2 +-
.../org/apache/beam/sdk/io/datadog/DatadogIO.java | 2 --
.../beam/sdk/io/elasticsearch/ElasticsearchIO.java | 2 +-
.../JsonReadSchemaTransformFormatProviderTest.java | 8 +++---
.../io/gcp/bigquery/UpdateSchemaDestination.java | 11 +++-----
.../beam/sdk/io/gcp/bigquery/WriteTables.java | 2 +-
...ueryStorageWriteApiSchemaTransformProvider.java | 4 +--
.../pubsub/PubsubReadSchemaTransformProvider.java | 2 +-
.../apache/beam/sdk/io/gcp/spanner/SpannerIO.java | 5 ----
.../SpannerWriteSchemaTransformProvider.java | 4 +--
.../io/gcp/bigquery/BigQueryIOStorageReadTest.java | 5 +++-
.../dao/ChangeStreamResultSetTest.java | 1 -
.../java/org/apache/beam/sdk/io/hbase/HBaseIO.java | 4 +--
.../sdk/io/iceberg/WriteDirectRowsToFiles.java | 2 +-
.../io/jdbc/JdbcWriteSchemaTransformProvider.java | 2 +-
.../java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java | 3 ++-
.../org/apache/beam/sdk/io/kafka/KafkaIOIT.java | 1 +
.../KafkaUnboundedReaderIdlePartitionTest.java | 2 +-
.../java/org/apache/beam/sdk/io/kudu/KuduIO.java | 6 +++--
.../apache/beam/sdk/io/pulsar/PulsarIOUtils.java | 3 ---
.../apache/beam/sdk/io/pulsar/PulsarIOTest.java | 3 ---
.../beam/sdk/io/singlestore/SingleStoreIO.java | 5 ++--
.../ml/inference/remote/RemoteInferenceTest.java | 18 +++++--------
.../beam/sdk/testing/TestPipelineExtension.java | 1 -
.../sdk/testutils/metrics/MetricsReaderTest.java | 2 +-
70 files changed, 156 insertions(+), 157 deletions(-)
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index f52105b786b..e284fc0b374 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1567,7 +1567,6 @@ class BeamModulePlugin implements Plugin<Project> {
"NullableTypeParameter",
"NullableWildcard",
"SuperCallToObjectMethod",
- "UnusedVariable",
// intended suppressions emerged in newer protobuf versions
// For backward compatibility. Public method checked in before
this check impl
// Possible use in interface subclasses
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
index 8b2b83b4d9a..1750cceffa0 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
@@ -90,7 +90,7 @@ public class
OutputAndTimeBoundedSplittableProcessElementInvokerTest {
}
@GetInitialRestriction
- public OffsetRange getInitialRestriction(@Element Void element) {
+ public OffsetRange getInitialRestriction(@SuppressWarnings("unused")
@Element Void element) {
throw new UnsupportedOperationException("Should not be called in this
test");
}
}
@@ -209,7 +209,8 @@ public class
OutputAndTimeBoundedSplittableProcessElementInvokerTest {
}
@GetInitialRestriction
- public OffsetRange getInitialRestriction(@Element Void element) {
+ public OffsetRange getInitialRestriction(
+ @SuppressWarnings("unused") @Element Void element) {
throw new UnsupportedOperationException("Should not be called in
this test");
}
};
@@ -228,7 +229,8 @@ public class
OutputAndTimeBoundedSplittableProcessElementInvokerTest {
}
@GetInitialRestriction
- public OffsetRange getInitialRestriction(@Element Void element) {
+ public OffsetRange getInitialRestriction(
+ @SuppressWarnings("unused") @Element Void element) {
throw new UnsupportedOperationException("Should not be called in
this test");
}
};
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java
index 9703c3c80bd..1ae937b7a83 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java
@@ -536,7 +536,8 @@ public class SimplePushbackSideInputDoFnRunnerTest {
public final StateSpec<ValueState<Integer>> intState =
StateSpecs.value(VarIntCoder.of());
@ProcessElement
- public void processElement(ProcessContext c, @StateId(stateId)
ValueState<Integer> state) {
+ public void processElement(
+ @SuppressWarnings("unused") ProcessContext c, @StateId(stateId)
ValueState<Integer> state) {
Integer currentValue = MoreObjects.firstNonNull(state.read(), 0);
state.write(currentValue + 1);
}
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
index 614721761f9..ef1f201ca1e 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
@@ -305,7 +305,8 @@ public class SplittableParDoProcessFnTest {
}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer elem) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer elem) {
return new SomeRestriction();
}
}
@@ -364,7 +365,7 @@ public class SplittableParDoProcessFnTest {
}
@GetInitialRestriction
- public OffsetRange getInitialRestriction(@Element Instant elem) {
+ public OffsetRange getInitialRestriction(@SuppressWarnings("unused")
@Element Instant elem) {
throw new IllegalStateException("Expected to be supplied explicitly in
this test");
}
@@ -446,7 +447,8 @@ public class SplittableParDoProcessFnTest {
}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer elem) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer elem) {
return new SomeRestriction();
}
}
@@ -509,7 +511,7 @@ public class SplittableParDoProcessFnTest {
}
@GetInitialRestriction
- public OffsetRange getInitialRestriction(@Element Integer elem) {
+ public OffsetRange getInitialRestriction(@SuppressWarnings("unused")
@Element Integer elem) {
throw new UnsupportedOperationException("Expected to be supplied
explicitly in this test");
}
}
@@ -630,12 +632,15 @@ public class SplittableParDoProcessFnTest {
private State state = State.BEFORE_SETUP;
@ProcessElement
- public void process(ProcessContext c, RestrictionTracker<SomeRestriction,
Void> tracker) {
+ public void process(
+ @SuppressWarnings("unused") ProcessContext c,
+ @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void>
tracker) {
assertEquals(State.INSIDE_BUNDLE, state);
}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer element) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer element) {
return new SomeRestriction();
}
diff --git
a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java
index 17b412349ea..b7cf0357447 100644
---
a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java
@@ -142,7 +142,9 @@ class DirectMetrics extends MetricResults {
* @param bundle The bundle being committed.
* @param finalCumulative The final cumulative value for the given bundle.
*/
- public void commitLogical(final CommittedBundle<?> bundle, final UpdateT
finalCumulative) {
+ public void commitLogical(
+ @SuppressWarnings("unused") final CommittedBundle<?> bundle,
+ final UpdateT finalCumulative) {
UpdateT current;
do {
current = finishedCommitted.get();
diff --git
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java
index 53c02e79600..39bcd5ae7f8 100644
---
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java
+++
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java
@@ -144,6 +144,6 @@ public class
DoFnLifecycleManagerRemovingTransformEvaluatorTest {
private static class TestFn extends DoFn<Object, Object> {
@ProcessElement
- public void processElement(ProcessContext c) throws Exception {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
throws Exception {}
}
}
diff --git
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java
index fc019b708c4..3963131ec6d 100644
---
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java
+++
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java
@@ -219,7 +219,7 @@ public class DoFnLifecycleManagerTest {
}
@ProcessElement
- public void processElement(ProcessContext c) throws Exception {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
throws Exception {}
@Teardown
public void teardown() {
diff --git
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java
index 49a4023b3b7..7a789b06a6f 100644
---
a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java
+++
b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java
@@ -111,7 +111,7 @@ public class DoFnLifecycleManagersTest {
}
@ProcessElement
- public void processElement(ProcessContext c) throws Exception {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
throws Exception {}
@Teardown
public void teardown() throws Exception {
@@ -165,6 +165,6 @@ public class DoFnLifecycleManagersTest {
private static class EmptyFn extends DoFn<Object, Object> {
@ProcessElement
- public void processElement(ProcessContext c) throws Exception {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
throws Exception {}
}
}
diff --git
a/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
b/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
index 7139a7d1634..0d48526e1d0 100644
---
a/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
+++
b/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
@@ -47,7 +47,6 @@ import org.apache.flink.configuration.RestartStrategyOptions;
import org.apache.flink.configuration.StateBackendOptions;
import org.apache.flink.configuration.TaskManagerOptions;
import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
-import org.apache.flink.runtime.state.StateBackend;
import org.apache.flink.runtime.util.EnvironmentInformation;
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.streaming.api.environment.LocalStreamEnvironment;
@@ -390,7 +389,6 @@ public class FlinkExecutionEnvironments {
}
private static void configureStateBackend(FlinkPipelineOptions options,
Configuration config) {
- final StateBackend stateBackend;
if (options.getStateBackend() != null) {
final String storagePath = options.getStateBackendStoragePath();
Preconditions.checkArgument(
diff --git
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
index 2134fa869b4..4ebb359fcea 100644
---
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
+++
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
@@ -1306,12 +1306,12 @@ public class ExecutableStageDoFnOperator<InputT,
OutputT>
private static class NoOpDoFn<InputT, OutputT> extends DoFn<InputT, OutputT>
{
@ProcessElement
- public void doNothing(ProcessContext context) {}
+ public void doNothing(@SuppressWarnings("unused") ProcessContext context)
{}
}
private static class StableNoOpDoFn<InputT, OutputT> extends DoFn<InputT,
OutputT> {
@RequiresStableInput
@ProcessElement
- public void doNothing(ProcessContext context) {}
+ public void doNothing(@SuppressWarnings("unused") ProcessContext context)
{}
}
}
diff --git
a/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java
b/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java
index bf07fe4cafc..edb6caee329 100644
---
a/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java
+++
b/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java
@@ -169,6 +169,7 @@ public class ReadSourcePortableTest implements Serializable
{
PipelineOptions options, @Nullable Checkpoint checkpointMark) {
return new UnboundedReader<Long>() {
+ @SuppressWarnings("unused")
int pos = -1;
@Override
@@ -230,6 +231,7 @@ public class ReadSourcePortableTest implements Serializable
{
}
private static class Checkpoint implements CheckpointMark, Serializable {
+ @SuppressWarnings("unused")
final int pos;
Checkpoint(int pos) {
diff --git
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
index 52b460302c1..8e5a91c0441 100644
---
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
+++
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
@@ -1828,12 +1828,14 @@ public class DataflowPipelineTranslatorTest implements
Serializable {
private static class TestSplittableFn extends DoFn<String, Integer> {
@ProcessElement
- public void process(ProcessContext c, RestrictionTracker<OffsetRange,
Long> tracker) {
+ public void process(
+ @SuppressWarnings("unused") ProcessContext c,
+ @SuppressWarnings("unused") RestrictionTracker<OffsetRange, Long>
tracker) {
// noop
}
@GetInitialRestriction
- public OffsetRange getInitialRange(@Element String element) {
+ public OffsetRange getInitialRange(@SuppressWarnings("unused") @Element
String element) {
return null;
}
}
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
index 172ca2b550c..51202459f8c 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
@@ -166,6 +166,8 @@ public final class StreamingDataflowWorker {
private static final String CHANNELZ_PATH = "/channelz";
private static final String BEAM_FN_API_EXPERIMENT = "beam_fn_api";
private static final String ELEMENT_METADATA_SUPPORTED_EXPERIMENT =
"element_metadata_supported";
+
+ @SuppressWarnings("unused")
private static final String
STREAMING_ENGINE_USE_JOB_SETTINGS_FOR_HEARTBEAT_POOL_EXPERIMENT =
"streaming_engine_use_job_settings_for_heartbeat_pool";
// Experiment make the monitor within BoundedQueueExecutor fair
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java
index c859b107171..4c7c1736462 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java
@@ -79,11 +79,13 @@ public class DebugCapture {
}
// Implicitly read. Not a bug.
+ @SuppressWarnings("unused")
@SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
@Key
public String name;
// Implicitly read. Not a bug.
+ @SuppressWarnings("unused")
@SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
@Key
public String content;
diff --git
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java
index 06138c02653..976c9eda476 100644
---
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java
+++
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java
@@ -63,7 +63,7 @@ public class DefaultParDoFnFactoryTest {
}
@ProcessElement
- public void processElement(ProcessContext c) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {
// This is called to ensure the SimpleParDoFn is fully initialized
}
}
diff --git
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java
index 7e53b155026..006232da3e1 100644
---
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java
+++
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java
@@ -48,7 +48,8 @@ public class DoFnInstanceManagersTest {
boolean tornDown = false;
@ProcessElement
- public void processElement(ProcessContext processContext) throws Exception
{}
+ public void processElement(@SuppressWarnings("unused") ProcessContext
processContext)
+ throws Exception {}
@Teardown
public void teardown() throws Exception {
diff --git
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
index ad958dcdf76..79419dd3a27 100644
---
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
+++
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
@@ -224,7 +224,7 @@ import org.slf4j.LoggerFactory;
/** Unit tests for {@link StreamingDataflowWorker}. */
@RunWith(Parameterized.class)
-@SuppressWarnings("deprecation")
+@SuppressWarnings({"deprecation", "unused"})
public class StreamingDataflowWorkerTest {
private static final Logger LOG =
LoggerFactory.getLogger(StreamingDataflowWorkerTest.class);
diff --git
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java
index 334b9414b26..e51be59cc4e 100644
---
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java
+++
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java
@@ -239,6 +239,7 @@ public class WorkerCustomSourcesTest {
}
private static class SourceWithLargeObject extends MockSource {
+ @SuppressWarnings("unused")
byte[] array;
public SourceWithLargeObject(int sourceObjectSize) {
diff --git
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandlerTest.java
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandlerTest.java
index 0f4752de169..c6a8581cf50 100644
---
a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandlerTest.java
+++
b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandlerTest.java
@@ -679,6 +679,7 @@ public class DataflowWorkerLoggingHandlerTest {
}
@Test
+ @SuppressWarnings("unused")
public void isConfiguredDirectLog() throws IOException {
ByteArrayOutputStream fileOutput = new ByteArrayOutputStream();
FixedOutputStreamFactory factory = new
FixedOutputStreamFactory(fileOutput);
diff --git
a/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java
b/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java
index 9296fcea359..76dcc0563e7 100644
---
a/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java
+++
b/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java
@@ -122,7 +122,7 @@ public class PortablePipelineJarCreatorTest implements
Serializable {
}
private static class FakePipelineRunnner {
- public static void main(String[] args) {
+ public static void main(@SuppressWarnings("unused") String[] args) {
System.out.println("Hello world");
}
}
@@ -145,7 +145,7 @@ public class PortablePipelineJarCreatorTest implements
Serializable {
@SuppressWarnings("IncorrectMainMethod") // intended
private static class EvilPipelineRunner {
- public static int main(String[] args) {
+ public static int main(@SuppressWarnings("unused") String[] args) {
return 0;
}
}
diff --git
a/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
b/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
index c5fdb125ad4..097eb4c256a 100644
---
a/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
+++
b/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
@@ -558,6 +558,6 @@ class ParDoBoundMultiTranslator<InT, OutT>
private static class NoOpDoFn<InT, OutT> extends DoFn<InT, OutT> {
@ProcessElement
- public void doNothing(ProcessContext context) {}
+ public void doNothing(@SuppressWarnings("unused") ProcessContext context)
{}
}
}
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java
index 86af822a6a4..10a3ea64956 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java
@@ -135,8 +135,7 @@ public class Select {
@FieldAccess("selectFields")
final FieldAccessDescriptor fieldAccess =
FieldAccessDescriptor.withAllFields();
- public SelectDoFn(
- FieldAccessDescriptor fieldAccessDescriptor, Schema inputSchema,
Schema outputSchema) {
+ public SelectDoFn(FieldAccessDescriptor fieldAccessDescriptor, Schema
inputSchema) {
this.rowSelector = new RowSelectorContainer(inputSchema,
fieldAccessDescriptor, true);
}
@@ -204,7 +203,7 @@ public class Select {
+ input.getSchema());
}
return input
- .apply(ParDo.of(new SelectDoFn<>(resolved, inputSchema,
outputSchema)))
+ .apply(ParDo.of(new SelectDoFn<>(resolved, inputSchema)))
.setRowSchema(outputSchema);
}
}
@@ -316,7 +315,7 @@ public class Select {
outputSchema = inferredOutputSchema;
}
return input
- .apply(ParDo.of(new SelectDoFn<>(fieldAccessDescriptor, inputSchema,
outputSchema)))
+ .apply(ParDo.of(new SelectDoFn<>(fieldAccessDescriptor,
inputSchema)))
.setRowSchema(outputSchema);
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java
index 36966c2d35d..bcc102edb7f 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java
@@ -282,7 +282,7 @@ public class CoderRegistryTest {
private static class OutputDoFn
extends DoFn<String, KV<String, MySerializableGeneric<String>>> {
@ProcessElement
- public void processElement(ProcessContext c) {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
{}
}
@Override
@@ -339,7 +339,7 @@ public class CoderRegistryTest {
private class OutputDoFn extends DoFn<String, KV<String,
MySerializableGeneric<T>>> {
@ProcessElement
- public void processElement(ProcessContext c) {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
{}
}
@Override
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
index 6a68769e370..2755ade271d 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
@@ -1957,7 +1957,8 @@ public class PipelineOptionsFactoryTest {
}
private static class RegisteredTestRunner extends
PipelineRunner<PipelineResult> {
- public static PipelineRunner<PipelineResult> fromOptions(PipelineOptions
options) {
+ public static PipelineRunner<PipelineResult> fromOptions(
+ @SuppressWarnings("unused") PipelineOptions options) {
return new RegisteredTestRunner();
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
index af1a5cb249b..45bcdc5c9ae 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
@@ -1244,6 +1244,7 @@ public class ProxyInvocationHandlerTest {
}
private static class CapturesOptions implements Serializable {
+ @SuppressWarnings("unused")
PipelineOptions options = PipelineOptionsFactory.create();
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java
index c831a6e562f..c6a2e55ea95 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java
@@ -94,7 +94,9 @@ public class JsonUtilsTest {
private static class TestCase<T extends RowEncodable> {
+ @SuppressWarnings("unused")
final String name;
+
final T userT;
final String jsonString;
final byte[] jsonBytes;
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java
index f27b936b711..cab3dac5ee2 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java
@@ -375,7 +375,7 @@ public class DoFnTesterTest {
}
@ProcessElement
- public void processElement(ProcessContext c) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {
elements++;
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java
index 05739c0f451..4c1c692765f 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java
@@ -462,7 +462,7 @@ public class WaitTest implements Serializable {
ParDo.of(
new DoFn<Long, Long>() {
@ProcessElement
- public void process(ProcessContext c, BoundedWindow w) {
+ public void process(ProcessContext c,
@SuppressWarnings("unused") BoundedWindow w) {
while (true) {
Instant maxMainTimestamp =
TEST_WAIT_MAX_MAIN_TIMESTAMP.get();
Instant newMaxTimestamp =
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java
index c80e92a897f..65372573fcd 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java
@@ -1217,7 +1217,7 @@ public class DisplayDataTest implements Serializable {
}
private static class HoldsItemSpecReference implements Serializable {
- public HoldsItemSpecReference(DisplayData.ItemSpec<?> spec) {}
+ public HoldsItemSpecReference(@SuppressWarnings("unused")
DisplayData.ItemSpec<?> spec) {}
}
@Test
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java
index f31899d118b..5921d6ee9c3 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java
@@ -47,6 +47,6 @@ public final class DefaultPackageTest {
private static class MyFn extends DoFn<String, String> {
@ProcessElement
- public void processElement(ProcessContext context) {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext
context) {}
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java
index 5a22203a8a7..8fabcc40956 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java
@@ -193,10 +193,12 @@ public class DoFnSignaturesSplittableDoFnTest {
private static class BaseFnWithoutContinuation extends DoFn<Integer, String>
{
@ProcessElement
public void processElement(
- ProcessContext context, RestrictionTracker<SomeRestriction, Void>
tracker) {}
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void>
tracker) {}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer element) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer element) {
return null;
}
}
@@ -204,12 +206,14 @@ public class DoFnSignaturesSplittableDoFnTest {
private static class BaseFnWithContinuation extends DoFn<Integer, String> {
@ProcessElement
public ProcessContinuation processElement(
- ProcessContext context, RestrictionTracker<SomeRestriction, Void>
tracker) {
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void>
tracker) {
return null;
}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer element) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer element) {
return null;
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java
index 019f6834793..19f081bdd83 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java
@@ -129,6 +129,6 @@ public class PTransformReplacementsTest {
private static class TestDoFn extends DoFn<Long, Long> {
@ProcessElement
- public void process(ProcessContext context) {}
+ public void process(@SuppressWarnings("unused") ProcessContext context) {}
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java
index e0ca074f822..30be422b2ee 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java
@@ -159,7 +159,7 @@ public class PTransformTranslationTest {
private static class TestDoFn extends DoFn<Long, KV<Long, String>> {
// Exists to stop the ParDo application from throwing
@ProcessElement
- public void process(ProcessContext context) {}
+ public void process(@SuppressWarnings("unused") ProcessContext context) {}
}
private static AppliedPTransform<?, ?, ?> generateSequence(Pipeline
pipeline) {
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java
index 6ef83603819..47b00a75e1d 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java
@@ -280,7 +280,9 @@ public class ParDoTranslationTest {
private static class DropElementsFn extends DoFn<KV<Long, String>, Void> {
@ProcessElement
- public void proc(ProcessContext context, BoundedWindow window) {
+ public void proc(
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") BoundedWindow window) {
context.output(null);
}
@@ -297,17 +299,20 @@ public class ParDoTranslationTest {
private static class SplittableDropElementsFn extends DoFn<KV<Long, String>,
Void> {
@ProcessElement
- public void proc(ProcessContext context, RestrictionTracker<Integer, ?>
restriction) {
+ public void proc(
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") RestrictionTracker<Integer, ?>
restriction) {
context.output(null);
}
@GetInitialRestriction
- public Integer restriction(@Element KV<Long, String> elem) {
+ public Integer restriction(@SuppressWarnings("unused") @Element KV<Long,
String> elem) {
return 42;
}
@NewTracker
- public RestrictionTracker<Integer, ?> newTracker(@Restriction Integer
restriction) {
+ public RestrictionTracker<Integer, ?> newTracker(
+ @SuppressWarnings("unused") @Restriction Integer restriction) {
throw new UnsupportedOperationException("Should never be called; only to
test translation");
}
@@ -388,7 +393,7 @@ public class ParDoTranslationTest {
public static class BundleFinalizerTranslation {
private static class StartBundleDoFn extends DoFn<String, String> {
@StartBundle
- public void startBundle(BundleFinalizer bundleFinalizer) {}
+ public void startBundle(@SuppressWarnings("unused") BundleFinalizer
bundleFinalizer) {}
@ProcessElement
public void processElement() {}
@@ -396,15 +401,15 @@ public class ParDoTranslationTest {
private static class ProcessContextDoFn extends DoFn<String, String> {
@ProcessElement
- public void processElement(BundleFinalizer finalizer) {}
+ public void processElement(@SuppressWarnings("unused") BundleFinalizer
finalizer) {}
}
private static class FinishBundleDoFn extends DoFn<String, String> {
@FinishBundle
- public void finishBundle(BundleFinalizer bundleFinalizer) {}
+ public void finishBundle(@SuppressWarnings("unused") BundleFinalizer
bundleFinalizer) {}
@ProcessElement
- public void processElement(BundleFinalizer finalizer) {}
+ public void processElement(@SuppressWarnings("unused") BundleFinalizer
finalizer) {}
}
@Test
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java
index e3521f257d4..d90efae4fb3 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java
@@ -275,7 +275,7 @@ public class PipelineTranslationTest {
private static class DoFnRequiringStableInput extends DoFn<Integer, String> {
@RequiresStableInput
@ProcessElement
- public void process(ProcessContext c) {
+ public void process(@SuppressWarnings("unused") ProcessContext c) {
// actually never executed and no effect on translation
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java
index 470d3071024..c6e0ebfecaf 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java
@@ -106,10 +106,12 @@ public class SplittableParDoTest {
private static class BoundedFakeFn extends DoFn<Integer, String> {
@ProcessElement
public void processElement(
- ProcessContext context, RestrictionTracker<SomeRestriction, Void>
tracker) {}
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void>
tracker) {}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer element) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer element) {
return null;
}
}
@@ -117,12 +119,14 @@ public class SplittableParDoTest {
private static class UnboundedFakeFn extends DoFn<Integer, String> {
@ProcessElement
public ProcessContinuation processElement(
- ProcessContext context, RestrictionTracker<SomeRestriction, Void>
tracker) {
+ @SuppressWarnings("unused") ProcessContext context,
+ @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void>
tracker) {
return stop();
}
@GetInitialRestriction
- public SomeRestriction getInitialRestriction(@Element Integer element) {
+ public SomeRestriction getInitialRestriction(
+ @SuppressWarnings("unused") @Element Integer element) {
return null;
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java
index d43d59a8839..484fea20e24 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java
@@ -171,7 +171,8 @@ public class FieldAccessVisitorTest {
@ProcessElement
public void processElement(
- @FieldAccess("row") Row row, OutputReceiver<Row>
outputReceiver)
+ @SuppressWarnings("unused") @FieldAccess("row") Row
row,
+ @SuppressWarnings("unused") OutputReceiver<Row>
outputReceiver)
throws Exception {
// Do nothing; we don't need to execute this DoFn.
}
@@ -183,7 +184,7 @@ public class FieldAccessVisitorTest {
/** Just some random DoFn without field access information. */
private static class UnknownDoFn extends DoFn<Row, Row> {
@ProcessElement
- public void processElement(ProcessContext c) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {
// Do nothing; we don't need to execute this DoFn.
}
}
@@ -191,7 +192,7 @@ public class FieldAccessVisitorTest {
/** Just some random DoFn that process raw strings, no Rows or Schemas
involved. */
private static class StringDoFn extends DoFn<String, String> {
@ProcessElement
- public void processElement(ProcessContext c) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {
// Do nothing; we don't need to execute this DoFn.
}
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java
index 4644e2458dc..0bed65f4f42 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java
@@ -240,7 +240,7 @@ public class ProjectionProducerVisitorTest {
private static class NoOpDoFn<T> extends DoFn<T, Row> {
@ProcessElement
- public void processElement(ProcessContext c) {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {}
}
private static class MultipleOutputSourceWithPushdown extends
PTransform<PBegin, PCollectionTuple>
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java
index 8dd428717d1..bb455620393 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java
@@ -185,7 +185,8 @@ public class ProjectionPushdownOptimizerTest {
@ProcessElement
public void processElement(
- @FieldAccess("row") Row row, OutputReceiver<Row>
outputReceiver)
+ @SuppressWarnings("unused") @FieldAccess("row") Row
row,
+ @SuppressWarnings("unused") OutputReceiver<Row>
outputReceiver)
throws Exception {
// Do nothing; we don't need to execute this DoFn.
}
@@ -293,7 +294,7 @@ public class ProjectionPushdownOptimizerTest {
private static class NoOpDoFn<T> extends DoFn<T, Row> {
@ProcessElement
- public void processElement(ProcessContext c) {}
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {}
}
private static class MultipleOutputSourceWithPushdown extends
PTransform<PBegin, PCollectionTuple>
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java
index 9ff66488759..a378cbbf31b 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java
@@ -370,7 +370,7 @@ public class QueryablePipelineTest {
private static class TestFn extends DoFn<byte[], Long> {
@ProcessElement
- public void process(ProcessContext ctxt) {}
+ public void process(@SuppressWarnings("unused") ProcessContext ctxt) {}
}
@Test
diff --git
a/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
b/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
index ae658d93955..ce99ae9ca59 100644
---
a/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
+++
b/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
@@ -892,7 +892,7 @@ public class ExpansionService extends
ExpansionServiceGrpc.ExpansionServiceImplB
}
private static class NotRunnableRunner extends
PipelineRunner<PipelineResult> {
- public static NotRunnableRunner fromOptions(PipelineOptions opts) {
+ public static NotRunnableRunner fromOptions(@SuppressWarnings("unused")
PipelineOptions opts) {
return new NotRunnableRunner();
}
diff --git
a/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java
b/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java
index df871432c43..69dfe71ee0b 100644
---
a/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java
+++
b/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java
@@ -921,6 +921,7 @@ public class AvroCoderTest {
@AvroSchema(
"{\"name\": \"bar\", \"type\": \"record\", \"fields\": ["
+ "{\"name\": \"foo\", \"type\": \"int\"}]}")
+ @SuppressWarnings("unused")
GenericRecord genericRecord;
}
@@ -938,6 +939,7 @@ public class AvroCoderTest {
@AvroSchema(
"{\"name\": \"bar\", \"type\": \"record\", \"fields\": ["
+ "{\"name\": \"foo\", \"type\": \"int\"}]}")
+ @SuppressWarnings("unused")
int withCustomSchema;
}
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java
index 2255a0ebcc8..d5684b4c2ae 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java
@@ -650,7 +650,6 @@ public class NFA implements Serializable {
private final CEPOperation
condition; // condition to evaluate when taking the "begin" action and
"proceed" action
private State nextState = null;
- public final boolean isStart;
public final boolean isFinal;
private final boolean
isKleenePlusSecondary; // whether is the second state for a Kleene
Plus pattern variable
@@ -659,13 +658,11 @@ public class NFA implements Serializable {
String patternVar,
Quantifier quant,
CEPOperation condition,
- boolean isStart,
boolean isFinal,
boolean isKleenePlusSecondary) {
this.patternVar = patternVar;
this.quant = quant;
this.condition = condition;
- this.isStart = isStart;
this.isFinal = isFinal;
this.isKleenePlusSecondary = isKleenePlusSecondary;
}
@@ -764,16 +761,9 @@ public class NFA implements Serializable {
// constructs states for the NFA and returns the start state
private State loadStates(List<CEPPattern> patterns) {
- boolean startState;
ArrayList<State> states = new ArrayList<>();
for (int i = 0; i < patterns.size(); ++i) {
- if (i == 0) {
- startState = true;
- } else {
- startState = false;
- }
-
CEPPattern currentPattern = patterns.get(i);
CEPOperation condition = currentPattern.getPatternCondition();
Quantifier quantifier = currentPattern.getQuantifier();
@@ -782,35 +772,22 @@ public class NFA implements Serializable {
// for Kleene plus, we need a pair of states
State primaryState =
- new State(
- currentPattern.getPatternVar(),
- Quantifier.PLUS,
- condition,
- startState,
- false,
- false);
+ new State(currentPattern.getPatternVar(), Quantifier.PLUS,
condition, false, false);
State secondaryState =
- new State(
- currentPattern.getPatternVar(),
- Quantifier.PLUS,
- condition,
- startState,
- false,
- true);
+ new State(currentPattern.getPatternVar(), Quantifier.PLUS,
condition, false, true);
primaryState.setNextState(secondaryState);
states.add(primaryState);
} else {
// for non-Kleene-Plus pattern var, construct a single state
State newState =
- new State(
- currentPattern.getPatternVar(), quantifier, condition,
startState, false, false);
+ new State(currentPattern.getPatternVar(), quantifier, condition,
false, false);
states.add(newState);
}
}
// add final state
- State theFinalState = new State("", Quantifier.NONE, null, false, true,
false);
+ State theFinalState = new State("", Quantifier.NONE, null, true, false);
states.add(theFinalState);
State beginState = setNextStatesAndAssignIndices(states);
return beginState;
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
index c54ab14ba8d..d5baf29fca2 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
@@ -407,7 +407,7 @@ public class BeamEnumerableConverter extends ConverterImpl
implements Enumerable
final Counter rows = Metrics.counter(BeamEnumerableConverter.class,
"rows");
@ProcessElement
- public void processElement(ProcessContext context) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext
context) {
rows.inc();
}
}
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java
index b47ff66329d..e597b6c63ed 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java
@@ -285,7 +285,9 @@ public class BeamWindowRel extends Window implements
BeamRelNode {
return new DoFn<List<Row>, Row>() {
@ProcessElement
public void processElement(
- @Element List<Row> inputPartition, OutputReceiver<Row> out,
ProcessContext c) {
+ @Element List<Row> inputPartition,
+ OutputReceiver<Row> out,
+ @SuppressWarnings("unused") ProcessContext c) {
List<Row> sortedRowsAsList = inputPartition;
NavigableMap<BigDecimal, List<Row>> indexRange = null;
if (!fieldAgg.rows) {
@@ -406,7 +408,7 @@ public class BeamWindowRel extends Window implements
BeamRelNode {
public void processElement(
@Element KV<Row, Iterable<Row>> inputPartition,
OutputReceiver<Iterable<Row>> out,
- ProcessContext c) {
+ @SuppressWarnings("unused") ProcessContext c) {
out.output(inputPartition.getValue());
}
}
@@ -415,7 +417,9 @@ public class BeamWindowRel extends Window implements
BeamRelNode {
return new DoFn<Iterable<Row>, List<Row>>() {
@ProcessElement
public void processElement(
- @Element Iterable<Row> inputPartition, OutputReceiver<List<Row>>
out, ProcessContext c) {
+ @Element Iterable<Row> inputPartition,
+ OutputReceiver<List<Row>> out,
+ @SuppressWarnings("unused") ProcessContext c) {
List<Row> partitionRows = Lists.newArrayList(inputPartition);
BeamSortRel.BeamSqlRowComparator beamSqlRowComparator =
new BeamSortRel.BeamSqlRowComparator(
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java
index 99915b33bf8..697643d4715 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java
@@ -146,7 +146,7 @@ public class BeamEnumerableConverterTest {
ParDo.of(
new DoFn<Row, Void>() {
@ProcessElement
- public void processElement(ProcessContext context) {}
+ public void processElement(@SuppressWarnings("unused")
ProcessContext context) {}
}));
return PDone.in(input.getPipeline());
}
diff --git
a/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java
b/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java
index fa8b6befaba..c52d38c73e6 100644
---
a/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java
+++
b/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java
@@ -210,11 +210,9 @@ public class DatadogIO {
private static class CreateKeysFn extends DoFn<DatadogEvent, KV<Integer,
DatadogEvent>> {
- @Nullable private Integer specifiedParallelism;
private Integer calculatedParallelism;
CreateKeysFn(@Nullable Integer specifiedParallelism) {
- this.specifiedParallelism = specifiedParallelism;
this.calculatedParallelism =
MoreObjects.firstNonNull(specifiedParallelism,
DEFAULT_PARALLELISM);
LOG.info("Parallelism set to: {}", calculatedParallelism);
diff --git
a/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
b/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
index 1cebd404bab..80f421d2937 100644
---
a/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
+++
b/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
@@ -2746,7 +2746,7 @@ public class ElasticsearchIO {
}
@StartBundle
- public void startBundle(StartBundleContext context) {
+ public void startBundle(@SuppressWarnings("unused") StartBundleContext
context) {
batch = new ArrayList<>();
currentBatchSizeBytes = 0;
}
diff --git
a/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java
b/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java
index e4bc63cd8d8..4138d00e648 100644
---
a/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java
+++
b/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java
@@ -200,11 +200,9 @@ public class JsonReadSchemaTransformFormatProviderTest
}
private static class CreateKVJsonString extends SimpleFunction<Long,
KV<Integer, String>> {
- Schema schema;
PayloadSerializer payloadSerializer;
- CreateKVJsonString(Schema schema, PayloadSerializer payloadSerializer) {
- this.schema = schema;
+ CreateKVJsonString(PayloadSerializer payloadSerializer) {
this.payloadSerializer = payloadSerializer;
}
@@ -248,7 +246,7 @@ public class JsonReadSchemaTransformFormatProviderTest
.withAllowedLateness(Duration.ZERO)
.triggering(Repeatedly.forever(AfterPane.elementCountAtLeast(1)))
.discardingFiredPanes())
- .apply(MapElements.via(new CreateKVJsonString(schema,
payloadSerializer)))
+ .apply(MapElements.via(new CreateKVJsonString(payloadSerializer)))
.setCoder(KvCoder.of(VarIntCoder.of(), StringUtf8Coder.of()))
.apply(
FileIO.<Integer, KV<Integer, String>>writeDynamic()
@@ -280,7 +278,7 @@ public class JsonReadSchemaTransformFormatProviderTest
// Write rows to dynamic destinations (test_1.., test_2.., test_3..)
writePipeline
.apply(Create.of(Arrays.asList(0L, 1L, 2L)))
- .apply(MapElements.via(new CreateKVJsonString(schema,
payloadSerializer)))
+ .apply(MapElements.via(new CreateKVJsonString(payloadSerializer)))
.setCoder(KvCoder.of(VarIntCoder.of(), StringUtf8Coder.of()))
.apply(
FileIO.<Integer, KV<Integer, String>>writeDynamic()
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java
index 65bb3bf11b1..b9cd554b578 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java
@@ -80,15 +80,10 @@ public class UpdateSchemaDestination<DestinationT>
private static class PendingJobData {
final BigQueryHelpers.PendingJob retryJob;
final TableDestination tableDestination;
- final BoundedWindow window;
- public PendingJobData(
- BigQueryHelpers.PendingJob retryJob,
- TableDestination tableDestination,
- BoundedWindow window) {
+ public PendingJobData(BigQueryHelpers.PendingJob retryJob,
TableDestination tableDestination) {
this.retryJob = retryJob;
this.tableDestination = tableDestination;
- this.window = window;
}
}
@@ -145,7 +140,7 @@ public class UpdateSchemaDestination<DestinationT>
public void processElement(
@Element Iterable<KV<DestinationT, WriteTables.Result>> element,
ProcessContext context,
- BoundedWindow window)
+ @SuppressWarnings("unused") BoundedWindow window)
throws IOException {
dynamicDestinations.setSideInputAccessorFromProcessContext(context);
List<KV<TableDestination, WriteTables.Result>> outputs =
Lists.newArrayList();
@@ -179,7 +174,7 @@ public class UpdateSchemaDestination<DestinationT>
schemaUpdateOptions);
if (updateSchemaDestinationJob != null) {
pendingJobs.put(
- destination, new PendingJobData(updateSchemaDestinationJob,
tableDestination, window));
+ destination, new PendingJobData(updateSchemaDestinationJob,
tableDestination));
}
}
if (!pendingJobs.isEmpty()) {
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java
index c952522202f..070f849e43e 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java
@@ -178,7 +178,7 @@ class WriteTables<DestinationT extends @NonNull Object>
private List<PendingJobData> pendingJobs = Lists.newArrayList();
@StartBundle
- public void startBundle(StartBundleContext c) {
+ public void startBundle(@SuppressWarnings("unused") StartBundleContext c) {
// Clear the map on each bundle so we can notice side-input updates.
// (alternative is to use a cache with a TTL).
jsonSchemas.clear();
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
index f9f86cc8018..e3d94723501 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
@@ -155,7 +155,7 @@ public class BigQueryStorageWriteApiSchemaTransformProvider
}
@FinishBundle
- public void finish(FinishBundleContext c) {
+ public void finish(@SuppressWarnings("unused") FinishBundleContext c) {
this.bqGenericElementCounter.inc(this.elementsInBundle);
this.elementsInBundle = 0L;
}
@@ -170,7 +170,7 @@ public class BigQueryStorageWriteApiSchemaTransformProvider
private static class NoOutputDoFn<T> extends DoFn<T, Row> {
@ProcessElement
- public void process(ProcessContext c) {}
+ public void process(@SuppressWarnings("unused") ProcessContext c) {}
}
@Override
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
index 8a628817fe2..c690115045b 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java
@@ -233,7 +233,7 @@ public class PubsubReadSchemaTransformProvider
}
@FinishBundle
- public void finish(FinishBundleContext c) {
+ public void finish(@SuppressWarnings("unused") FinishBundleContext c) {
pubsubErrorCounter.inc(errorsInBundle);
errorsInBundle = 0L;
}
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
index e19137abb40..9f3c7c0d629 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
@@ -2014,11 +2014,6 @@ public class SpannerIO {
getMetadataInstance(),
changeStreamDatabaseId.getInstanceId().getInstance());
final String partitionMetadataDatabaseId =
MoreObjects.firstNonNull(getMetadataDatabase(),
changeStreamDatabaseId.getDatabase());
- final DatabaseId fullPartitionMetadataDatabaseId =
- DatabaseId.of(
- getSpannerConfig().getProjectId().get(),
- partitionMetadataInstanceId,
- partitionMetadataDatabaseId);
final SpannerConfig changeStreamSpannerConfig =
buildChangeStreamSpannerConfig();
final SpannerConfig partitionMetadataSpannerConfig =
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java
index 61955f448c3..eee13b0a932 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java
@@ -132,7 +132,7 @@ public class SpannerWriteSchemaTransformProvider
}
@FinishBundle
- public void finish(FinishBundleContext c) {
+ public void finish(@SuppressWarnings("unused") FinishBundleContext c) {
this.spannerGenericElementCounter.inc(this.elementsInBundle);
this.elementsInBundle = 0L;
}
@@ -140,7 +140,7 @@ public class SpannerWriteSchemaTransformProvider
private static class NoOutputDoFn<T> extends DoFn<T, Row> {
@ProcessElement
- public void process(ProcessContext c) {}
+ public void process(@SuppressWarnings("unused") ProcessContext c) {}
}
@Override
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java
index 95f472f5c61..db5777627a3 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java
@@ -2675,7 +2675,10 @@ public class BigQueryIOStorageReadTest {
}
private ReadRowsResponse createAvroTsResponse(
- Schema avroSchema, TimestampPrecision precision, List<Object>
inputValues) throws Exception {
+ Schema avroSchema,
+ @SuppressWarnings("unused") TimestampPrecision precision,
+ List<Object> inputValues)
+ throws Exception {
List<GenericRecord> records = new ArrayList<>();
for (Object value : inputValues) {
GenericRecord record = new Record(avroSchema);
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java
index d3408536c82..cd4715b063f 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java
@@ -34,7 +34,6 @@ public class ChangeStreamResultSetTest {
@Test
public void testGetBytes() throws Exception {
// 1. Create an expected ChangeStreamRecord proto
- Timestamp now = Timestamp.now();
final HeartbeatRecord heartbeatRecord =
new HeartbeatRecord(Timestamp.ofTimeSecondsAndNanos(10L, 20), null);
com.google.spanner.v1.ChangeStreamRecord expectedRecord =
recordToProto(heartbeatRecord);
diff --git
a/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
b/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
index b407be75161..b70bfcc3ad8 100644
--- a/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
+++ b/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
@@ -745,7 +745,7 @@ public class HBaseIO {
}
@StartBundle
- public void startBundle(StartBundleContext c) throws IOException {
+ public void startBundle(@SuppressWarnings("unused") StartBundleContext
c) throws IOException {
BufferedMutatorParams params = new
BufferedMutatorParams(TableName.valueOf(tableId));
mutator = connection.getBufferedMutator(params);
recordsWritten = 0;
@@ -913,7 +913,7 @@ public class HBaseIO {
}
@StartBundle
- public void startBundle(StartBundleContext c) throws IOException {
+ public void startBundle(@SuppressWarnings("unused") StartBundleContext
c) throws IOException {
table = connection.getTable(TableName.valueOf(tableId));
recordsWritten = 0;
}
diff --git
a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java
b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java
index 8835e2ff628..fbd6c15095e 100644
---
a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java
+++
b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java
@@ -98,7 +98,7 @@ class WriteDirectRowsToFiles
@ProcessElement
public void processElement(
- ProcessContext context,
+ @SuppressWarnings("unused") ProcessContext context,
@Element KV<String, Row> element,
BoundedWindow window,
PaneInfo paneInfo)
diff --git
a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
index 4dbb9b396f0..3386fbe090d 100644
---
a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
+++
b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java
@@ -238,7 +238,7 @@ public class JdbcWriteSchemaTransformProvider
private static class NoOutputDoFn<T> extends DoFn<T, Row> {
@ProcessElement
- public void process(ProcessContext c) {}
+ public void process(@SuppressWarnings("unused") ProcessContext c) {}
}
@Override
diff --git
a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
index 2c712b39752..57074fdffe8 100644
--- a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
+++ b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
@@ -308,7 +308,8 @@ public class JdbcIOIT {
private final long numRecords;
private final long numPerPeriod;
- public GenerateRecordsStream(long numRecords, long numPerPeriod, Duration
periodLength) {
+ public GenerateRecordsStream(
+ long numRecords, long numPerPeriod, @SuppressWarnings("unused")
Duration periodLength) {
this.numRecords = numRecords;
this.numPerPeriod = numPerPeriod;
}
diff --git
a/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
b/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
index b7426c336d6..94920a61869 100644
---
a/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
+++
b/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
@@ -827,6 +827,7 @@ public class KafkaIOIT {
assertNotEquals(PipelineResult.State.FAILED, writeState);
sdfReadPipeline.getOptions().as(Options.class).setStreaming(false);
+ @SuppressWarnings("unused")
PCollection<KafkaRecord<byte[], byte[]>> rows =
sdfReadPipeline.apply(
"Read from bounded Kafka",
diff --git
a/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReaderIdlePartitionTest.java
b/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReaderIdlePartitionTest.java
index 005cd6fa378..4c6f6dd79fc 100644
---
a/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReaderIdlePartitionTest.java
+++
b/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReaderIdlePartitionTest.java
@@ -173,7 +173,7 @@ public class KafkaUnboundedReaderIdlePartitionTest {
List<String> topics,
int partitionsPerTopic,
int numElements,
- Map<String, Object> config,
+ @SuppressWarnings("unused") Map<String, Object> config,
SerializableFunction<Integer, byte[]> keyFunction,
SerializableFunction<Integer, byte[]> valueFunction) {
diff --git
a/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java
b/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java
index 6d6296733db..795c0187b94 100644
--- a/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java
+++ b/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java
@@ -430,12 +430,14 @@ public class KuduIO {
}
@StartBundle
- public void startBundle(StartBundleContext context) throws KuduException
{
+ public void startBundle(@SuppressWarnings("unused") StartBundleContext
context)
+ throws KuduException {
writer.openSession();
}
@ProcessElement
- public void processElement(ProcessContext c) throws KuduException {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c)
+ throws KuduException {
writer.write(c.element());
}
diff --git
a/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java
b/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java
index 8c4a3af282e..6f401161a12 100644
---
a/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java
+++
b/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java
@@ -21,12 +21,9 @@ import org.apache.beam.sdk.transforms.SerializableFunction;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.api.PulsarClient;
import org.apache.pulsar.client.api.PulsarClientException;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
final class PulsarIOUtils {
- private static final Logger LOG =
LoggerFactory.getLogger(PulsarIOUtils.class);
static final String LOCAL_SERVICE_URL = "pulsar://localhost:6650";
static final long DEFAULT_CONSUMER_POLLING_TIMEOUT = 2L;
diff --git
a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java
b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java
index 52ee3044d60..37f48672b73 100644
---
a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java
+++
b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java
@@ -32,15 +32,12 @@ import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
// TODO(https://github.com/apache/beam/issues/31078) exceptions are currently
suppressed
@SuppressWarnings("Slf4jDoNotLogMessageOfExceptionExplicitly")
@RunWith(JUnit4.class)
public class PulsarIOTest implements Serializable {
@Rule public final transient TestPipeline pipeline = TestPipeline.create();
- private static final Logger LOG =
LoggerFactory.getLogger(PulsarIOTest.class);
private static final String TEST_TOPIC = "TEST_TOPIC";
// In order to pin fake readers having same set of messages
diff --git
a/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java
b/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java
index db5ae34d737..fd2e8d17233 100644
---
a/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java
+++
b/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java
@@ -734,13 +734,14 @@ public class SingleStoreIO {
}
@GetInitialRestriction
- public OffsetRange getInitialRange(@Element ParameterT element) throws
Exception {
+ public OffsetRange getInitialRange(@SuppressWarnings("unused") @Element
ParameterT element)
+ throws Exception {
return new OffsetRange(0L, getNumPartitions());
}
@SplitRestriction
public void splitRange(
- @Element ParameterT element,
+ @SuppressWarnings("unused") @Element ParameterT element,
@Restriction OffsetRange range,
OutputReceiver<OffsetRange> receiver) {
for (long i = range.getFrom(); i < range.getTo(); i++) {
diff --git
a/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java
b/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java
index 4183906e769..eef47dddfcd 100644
---
a/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java
+++
b/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java
@@ -178,12 +178,10 @@ public class RemoteInferenceTest {
public static class MockSuccessHandler
implements BaseModelHandler<TestParameters, TestInput, TestOutput> {
- private TestParameters parameters;
private boolean clientCreated = false;
@Override
- public void createClient(TestParameters parameters) {
- this.parameters = parameters;
+ public void createClient(@SuppressWarnings("unused") TestParameters
parameters) {
this.clientCreated = true;
}
@@ -203,7 +201,7 @@ public class RemoteInferenceTest {
implements BaseModelHandler<TestParameters, TestInput, TestOutput> {
@Override
- public void createClient(TestParameters parameters) {
+ public void createClient(@SuppressWarnings("unused") TestParameters
parameters) {
// Setup succeeds
}
@@ -218,7 +216,7 @@ public class RemoteInferenceTest {
implements BaseModelHandler<TestParameters, TestInput, TestOutput> {
@Override
- public void createClient(TestParameters parameters) {
+ public void createClient(@SuppressWarnings("unused") TestParameters
parameters) {
throw new RuntimeException("Setup failed intentionally");
}
@@ -233,7 +231,7 @@ public class RemoteInferenceTest {
implements BaseModelHandler<TestParameters, TestInput, TestOutput> {
@Override
- public void createClient(TestParameters parameters) {
+ public void createClient(@SuppressWarnings("unused") TestParameters
parameters) {
// Setup succeeds
}
@@ -247,14 +245,10 @@ public class RemoteInferenceTest {
public static class MockNoDefaultConstructorHandler
implements BaseModelHandler<TestParameters, TestInput, TestOutput> {
- private final String required;
-
- public MockNoDefaultConstructorHandler(String required) {
- this.required = required;
- }
+ public MockNoDefaultConstructorHandler(@SuppressWarnings("unused") String
required) {}
@Override
- public void createClient(TestParameters parameters) {}
+ public void createClient(@SuppressWarnings("unused") TestParameters
parameters) {}
@Override
public Iterable<PredictionResult<TestInput, TestOutput>>
request(List<TestInput> input) {
diff --git
a/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java
b/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java
index ef95dcd611b..12c05ff47fd 100644
---
a/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java
+++
b/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java
@@ -72,7 +72,6 @@ public class TestPipelineExtension
private static final ExtensionContext.Namespace NAMESPACE =
ExtensionContext.Namespace.create(TestPipelineExtension.class);
private static final String PIPELINE_KEY = "testPipeline";
- private static final String ENFORCEMENT_KEY = "enforcement";
/** Creates a new TestPipelineExtension with default options. */
public static TestPipelineExtension create() {
diff --git
a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
index e2fef254d13..d01ae06f309 100644
---
a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
+++
b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
@@ -121,7 +121,7 @@ public class MetricsReaderTest {
private final Counter elementCounter = Metrics.counter(NAMESPACE,
"counter");
@ProcessElement
- public void processElement(ProcessContext c) {
+ public void processElement(@SuppressWarnings("unused") ProcessContext c) {
elementCounter.inc();
}
}
