[ 
https://issues.apache.org/jira/browse/CASSANDRA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849925#action_12849925
 ] 

Eric Evans commented on CASSANDRA-850:
--------------------------------------

> Is there a reason to keep the junit 3.8.1 jar in lib and also use ivy to 
> fetch junit 4.6? 

We were explicitly pulling in junit 4.6 to use for our unit tests, and 
implicitly pulling in junit 3.8.1 as a dependency for at least one of those 
other jars in lib/ (Ivy would resolve that to 4.6 only). So that explains why 
it is the way it is, though I do suspect that the jar(s) that declared a 
dependency on junit did so in error, (or we simply don't exercise those parts 
of the lib(s)). 

The unit tests, system tests and cassandra-cli (one of those aforementioned 
jars is jline, used by the cli) all seem to work after removing 
lib/junit-3.8.1.jar , so it's probably safe to leave it out.

> Due to my lack of legal expertise I will assume the bits in the notice file 
> are sufficient. 

I'm not sure it would satisfy everyone on the incubator list, but it is correct 
with respect to the legal requirements, at least according to my understanding 
of the respective licenses (actually, it errs on the side of caution wherever I 
wasn't 100% sure).

> I remember someone voiced the opinion earlier that licenses should be pulled 
> into a single file in the root

That was something else that came up on the incubator list, and TTBOMK there 
wasn't consensus for this either. I can find no such requirement in my reading 
of the actual licenses. I can however append a sentence or two to LICENSE that 
refers to lib/license for third-party libs, (I think that would satisfy that 
camp).

> Ant release target doesn't include all jars in binary tarball
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-850
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>             Fix For: 0.6
>
>         Attachments: CASSANDRA-850.patch, 
> v2-0001-CASSANDRA-850-runtime-dependencies-formerly-handled-by.txt, 
> v2-0002-licensing-and-attribution-for-newly-added-jars.txt, 
> v2-0003-remove-default-runtime-ivy-config.txt, 
> v2-0004-remove-build-lib-jars-from-runtime-search-paths.txt, 
> v2-0005-do-not-ship-build.xml-and-ivy.xml-in-binary-dist.txt, 
> v2-0006-update-release-notes-and-readme-for-ivy-rollback.txt
>
>
> The ant release target doesn't create a complete tarball, the jars in 
> build/lib/jars are not included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to