[ 
https://issues.apache.org/jira/browse/CASSANDRA-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185028#comment-14185028
 ] 

Benjamin Lerer edited comment on CASSANDRA-7463 at 10/27/14 10:23 AM:
----------------------------------------------------------------------

Only one nit:
In {{AbstractSSTableSimpleWriter.makeFilename}} I think that
{code}int maxGen = generation.getAndIncrement();
for (Descriptor desc : existing)
{
    while (desc.generation > maxGen)
    {
        if (!generation.compareAndSet(maxGen, desc.generation + 1))
        {
            maxGen = generation.getAndIncrement();
        }
        else
        {
            maxGen = desc.generation;
        }
    }
    maxGen = Math.max(maxGen, desc.generation);
 }{code} 
could be replaced by 
{code}int maxGen = generation.getAndIncrement();
for (Descriptor desc : existing)
{
    while (desc.generation > maxGen)
    {
        maxGen = generation.getAndIncrement();
    }
}{code} 



was (Author: blerer):
Only one nit:
In {{AbstractSSTableSimpleWriter.makeFilename} I think that
{code}int maxGen = generation.getAndIncrement();
for (Descriptor desc : existing)
{
    while (desc.generation > maxGen)
    {
        maxGen = generation.getAndIncrement();
    }
}{code} could be replaced by 


> Update CQLSSTableWriter to allow parallel writing of SSTables on the same 
> table within the same JVM
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7463
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7463
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Johnny Miller
>            Assignee: Carl Yeksigian
>             Fix For: 2.0.12
>
>         Attachments: 7463-v2.txt, 7463.patch
>
>
> Currently it is not possible to programatically write multiple SSTables for 
> the same table in parallel using the CQLSSTableWriter. This is quite a 
> limitation and the workaround of attempting to do this in a separate JVM is 
> not a great solution.
> See: 
> http://stackoverflow.com/questions/24396902/using-cqlsstablewriter-concurrently



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to