[
https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638588#comment-14638588
]
Benedict edited comment on CASSANDRA-7066 at 7/23/15 12:53 PM:
---------------------------------------------------------------
Thanks. It's about ready I think. I've pushed some very small comments and
suggestions. Almost all minor clarity suggestions or comments, plus one issue
of "correctness": in {{TransactionLogs.complete}} we could possibly throw an
exception on {{selfRef.release}}, although this would be exceedingly unlikely,
and in fact probably impossible without a bug.
On the change to {{maybeFail}} in commit, I would prefer if we updated the test
for this class, as the failure behaviour is more correct.
If you can confirm you're happy with the changes, then rebase and get CI
results, I'll look to commit.
(the comment about multiple times, btw, was just because it looked at first
glance like encoding the functional testing you had would not have been
possible with a single class, as you tested multiple different pre-commit
states)
was (Author: benedict):
Thanks. It's about ready I think. I've pushed some very small comments and
suggestions. Almost all minor clarity suggestions or comments, plus one issue
of "correctness": in {{TransactionLogs.complete}} we could possibly throw an
exception on {{selfRef.release}}, although this would be exceedingly unlikely,
and in fact probably impossible without a bug.
If you can confirm you're happy with the changes, then rebase and get CI
results, I'll look to commit.
> Simplify (and unify) cleanup of compaction leftovers
> ----------------------------------------------------
>
> Key: CASSANDRA-7066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7066
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Priority: Minor
> Labels: benedict-to-commit, compaction
> Fix For: 3.x
>
> Attachments: 7066.txt
>
>
> Currently we manage a list of in-progress compactions in a system table,
> which we use to cleanup incomplete compactions when we're done. The problem
> with this is that 1) it's a bit clunky (and leaves us in positions where we
> can unnecessarily cleanup completed files, or conversely not cleanup files
> that have been superceded); and 2) it's only used for a regular compaction -
> no other compaction types are guarded in the same way, so can result in
> duplication if we fail before deleting the replacements.
> I'd like to see each sstable store in its metadata its direct ancestors, and
> on startup we simply delete any sstables that occur in the union of all
> ancestor sets. This way as soon as we finish writing we're capable of
> cleaning up any leftovers, so we never get duplication. It's also much easier
> to reason about.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
