[ 
https://issues.apache.org/jira/browse/CASSANDRA-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089748#comment-15089748
 ] 

Carl Yeksigian commented on CASSANDRA-9830:
-------------------------------------------

The cstar runs that you kicked off didn't work because you aren't on the list 
of repos for cstar, so I kicked off a new [ssd 
test|http://cstar.datastax.com/tests/id/7ebab860-b48f-11e5-9d2a-0256e416528f]. 
The increase looks modest, but there is an improvement.

[~enigmacurry] looks like the bdplab test never kicked off; can you take a 
look? Also, is there any way to get memory usage during the tests?

I think we should be skipping creating the bloom filter for the leveled major 
compaction as well. That's because in major compaction, while we aren't always 
adding at what ends up being the highest level after we are done, we are always 
writing the highest level for a given key. Plus, this will ensure that 
whichever level ends up as the highest will not have bloom filters.

Otherwise, code looks good.

> Option to disable bloom filter in highest level of LCS sstables
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-9830
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9830
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Compaction
>            Reporter: Jonathan Ellis
>            Assignee: Paulo Motta
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.x
>
>
> We expect about 90% of data to be in the highest level of LCS in a fully 
> populated series.  (See also CASSANDRA-9829.)
> Thus if the user is primarily asking for data (partitions) that has actually 
> been inserted, the bloom filter on the highest level only helps reject 
> sstables about 10% of the time.
> We should add an option that suppresses bloom filter creation on top-level 
> sstables.  This will dramatically reduce memory usage for LCS and may even 
> improve performance as we no longer check a low-value filter.
> (This is also an idea from RocksDB.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to