[ 
https://issues.apache.org/jira/browse/CASSANDRA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953719#comment-15953719
 ] 

Jeff Jirsa commented on CASSANDRA-13396:
----------------------------------------

There are really three issues:

1) The existing comments were clearly inadequate, and that's been ninja'd into 
place. +1 on that. 

2) Throwing a ClassCastException is objectively wrong. The patch fixes that, 
and should be committed. 

3) As a side effect, the patch allows other loggers, almost all of which are 
untested. The assertion from [~snazy] is that doing so is dangerous, 
specifically citing past bugs where other loggers which may do IO and cause 
sandbox access problems. That's a valid concern, and worth a logged warning in 
my opinion.

Like [~spo...@gmail.com] (and I think [~blerer]) suggest above, I think Ed's 
patch+warning makes sense to me.

If someone wants to "officially" support another logger in order to remove the 
warning, then I think the burden is on them to open a proper ticket and 
demonstrate that it's sufficiently tested.

> Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13396
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13396
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Edward Capriolo
>            Priority: Minor
>
> https://www.mail-archive.com/user@cassandra.apache.org/msg51603.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to