[ https://issues.apache.org/jira/browse/CASSANDRA-13385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000693#comment-16000693 ]
Benjamin Lerer commented on CASSANDRA-13385: -------------------------------------------- Thanks for the patch. +1 > Delegate utests index name creation to CQLTester.createIndex > ------------------------------------------------------------ > > Key: CASSANDRA-13385 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13385 > Project: Cassandra > Issue Type: Improvement > Components: Testing > Reporter: Andrés de la Peña > Assignee: Andrés de la Peña > Labels: cql, unit-test > > Currently, many unit tests rely on {{CQLTester.createIndex}} to create > indexes. The index name should be specified by the test itself, for example: > {code} > createIndex("CREATE CUSTOM INDEX myindex ON %s(c) USING > 'org.apache.cassandra.index.internal.CustomCassandraIndex'"); > {code} > Two different tests using the same index name can produce racy {{Index > myindex already exists}} errors due to the asynchronicity of > {{CQLTester.afterTest}} cleanup methods. > It would be nice to modify {{CQLTester.createIndex}} to make it generate its > own index names, as it is done by {{CQLTester.createTable}}: > {code} > createIndex("CREATE CUSTOM INDEX %s ON %s(c) USING > 'org.apache.cassandra.index.internal.CustomCassandraIndex'"); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org