[ 
https://issues.apache.org/jira/browse/CASSANDRA-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080530#comment-16080530
 ] 

ASF GitHub Bot commented on CASSANDRA-13683:
--------------------------------------------

GitHub user clohfink opened a pull request:

    https://github.com/apache/cassandra/pull/130

    Switch to client init for sstabledump for CASSANDRA-13683

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clohfink/cassandra 13683

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit b763eb2ac60bf35a3676c248e40c02a5737d094a
Author: Chris Lohfink <clohf...@apple.com>
Date:   2017-07-10T15:46:34Z

    Switch to client init for sstabledump for CASSANDRA-13683

----


> sstabledump should not use tool initialization
> ----------------------------------------------
>
>                 Key: CASSANDRA-13683
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13683
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>
> The tool initialization is not necessary for the sstabledump utility and by 
> using it we possibly introduce a unnecessary requirement of being on the same 
> C* instance (since we may introduce changes that require it, UDT changes can 
> lead to dangerous assumptions) that has the schema. This also does things 
> like introduce possibly devastating issues from having the same 
> commitlog/sstable locations.
> A good example is updating the sstable activity table, and having that 
> flushed to commitlogs as an application outside the running C* service. This 
> may not be on same user (ie root) which than when a postmemtable flusher 
> after restart attempts to delete it will throw an exception and potentially 
> kill that thread pool. One that happens commitlogs will cease to get recycled 
> and will just burn disk space until we run out.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to