[ https://issues.apache.org/jira/browse/CASSANDRA-14434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460571#comment-16460571 ]
Jaydeepkumar Chovatia commented on CASSANDRA-14434: --------------------------------------------------- It seems that many of the recent changes done as part of various JIRAs has broken {{eclipse-warnings}} 1. commit d31ed0f51b23d8fce892695ecd82d4f843f31f4c as part of CASSANDRA-14118 has introduced following two warnings: {quote}[java] 3. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/CassandraKeyspaceWriteHandler.java (at line 42) [java] group = Keyspace.writeOrder.start(); [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [java] Resource 'group' should be managed by try-with-resource [java] ---------- [java] 4. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/CassandraKeyspaceWriteHandler.java (at line 68) [java] group = Keyspace.writeOrder.start(); [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [java] Resource 'group' should be managed by try-with-resource [java] ---------- {quote} 2. commit 59b5b6bef0fa76bf5740b688fcd4d9cf525760d0 as part of CASSANDRA-7544 has introduced following two warnings: {quote}[[java] 1. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/net/MessageIn.java (at line 120) [java] builder.put(type, type.serializer.deserialize(new DataInputBuffer(value), version)); [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^ [java] Potential resource leak: '<unassigned Closeable value>' may not be closed [java] ---------- [java] ---------- [java] 2. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/net/async/MessageInHandler.java (at line 216) [java] parameters.put(parameterType, parameterType.serializer.deserialize(new DataInputBuffer(value), messagingVersion)); [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^ [java] Potential resource leak: '<unassigned Closeable value>' may not be closed {quote} and so on …. Let me work on fixing all the recent failures and submit the patch. > ant eclipse-warnings failing on trunk > ------------------------------------- > > Key: CASSANDRA-14434 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14434 > Project: Cassandra > Issue Type: Bug > Components: Build > Reporter: Jaydeepkumar Chovatia > Assignee: Jaydeepkumar Chovatia > Priority: Minor > > {{ant eclipse-warnings}} is been failing on last few builds > e.g. > https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-test-all/569/console > {quote} > eclipse-warnings: > [mkdir] Created dir: > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/build/ecj > [echo] Running Eclipse Code Analysis. Output logged to > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/build/ecj/eclipse_compiler_checks.txt > [java] ---------- > [java] 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/net/MessageIn.java > (at line 120) > [java] builder.put(type, type.serializer.deserialize(new > DataInputBuffer(value), version)); > [java] > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] Potential resource leak: '<unassigned Closeable value>' may not > be closed > [java] ---------- > [java] ---------- > [java] 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/net/async/MessageInHandler.java > (at line 216) > [java] parameters.put(parameterType, > parameterType.serializer.deserialize(new DataInputBuffer(value), > messagingVersion)); > [java] > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] Potential resource leak: '<unassigned Closeable value>' may not > be closed > [java] ---------- > [java] ---------- > [java] 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/CassandraKeyspaceWriteHandler.java > (at line 42) > [java] group = Keyspace.writeOrder.start(); > [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] Resource 'group' should be managed by try-with-resource > [java] ---------- > [java] 4. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/CassandraKeyspaceWriteHandler.java > (at line 68) > [java] group = Keyspace.writeOrder.start(); > [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > [java] Resource 'group' should be managed by try-with-resource > [java] ---------- > [java] ---------- > [java] 5. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/streaming/CassandraStreamReader.java > (at line 159) > [java] return writer; > [java] ^^^^^^^^^^^^^^ > [java] Potential resource leak: 'txn' may not be closed at this location > [java] ---------- > [java] ---------- > [java] 6. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-trunk-test-all/src/java/org/apache/cassandra/db/streaming/CassandraStreamReceiver.java > (at line 106) > [java] SSTableMultiWriter sstable = file.getSSTable(); > [java] ^^^^^^^ > [java] Potential resource leak: 'sstable' may not be closed > [java] ---------- > [java] 6 problems (6 errors) > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org