[ https://issues.apache.org/jira/browse/CASSANDRA-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-13529: ------------------------------------ Resolution: Fixed Fix Version/s: (was: 4.x) 4.0 Status: Resolved (was: Patch Available) OK, finally got around to finish up the review here. Everything was largely fine, but I've made some editorial choices: - moved {{ArgSelect}} to {{SchemaStatement}}. it seems out of place in a 'utils' class. - simplified implemention of {{dynamicConditionExists}} and moved it into {{StressProfile}} and thus eliminated {{QueryUtils}}. - eliminate the double checked locking in {{CASQuery.JavaDriverRun#bind()}} by moving the {{client#bind()}} into the constructor of the {{JavaDriverRun}}. - made some fields final and collections immutable in {{CASQuery}} - i've made a few minor cleanups (nothing significant) Committed as sha {{2aeed037e0f105e72366e15afa012257e910a25d}}. Thanks, [~chovatia.jayd...@gmail.com] and [~djoshi3]! > cassandra-stress light-weight transaction support > ------------------------------------------------- > > Key: CASSANDRA-13529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13529 > Project: Cassandra > Issue Type: New Feature > Components: Stress > Reporter: Jaydeepkumar Chovatia > Assignee: Jaydeepkumar Chovatia > Priority: Minor > Labels: LWT > Fix For: 4.0 > > Attachments: 13529.txt, lwttest.yaml > > > It would be nice to have a light-weight transaction support in > cassandra-stress. > Although currently in cassandra-stress we can achieve light-weight > transaction partially by using static conditions like "IF col1 != null" or > "IF not EXIST". > If would be ideal to have full fledged light-weight transaction support like > "IF col1 = ? and col2 = ?". One way to implement is to read values from > Cassandra and use that in the condition so it will execute all the paxos > phases in Cassandra. > Please find git link for the patch: > https://github.com/apache/cassandra/compare/trunk...jaydeepkumar1984:13529-trunk?expand=1 > ||trunk| > |[branch|https://github.com/jaydeepkumar1984/cassandra/tree/13529-trunk]| > |[utests|https://circleci.com/gh/jaydeepkumar1984/cassandra/8]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org