[ https://issues.apache.org/jira/browse/CASSANDRA-14806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683777#comment-16683777 ]
Marcus Eriksson commented on CASSANDRA-14806: --------------------------------------------- Just tried this on a new machine, have to say it is a bit annoying having to install circleci cli just to make a tiny change to a config file Maybe we could have the shipped {{.patch}} apply to the generated file instead? This way only people doing changes to {{circleci-2.1.yml}} would have to install the tool. Drawback would be that the person changing circle-2.1.yml would have to also provide a new patch for the generated file (though, it is likely this is the case even if we patch {{circleci-2.1.yml}} & generate {{config.yml}}) > CircleCI workflow improvements and Java 11 support > -------------------------------------------------- > > Key: CASSANDRA-14806 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14806 > Project: Cassandra > Issue Type: Improvement > Components: Build, Testing > Reporter: Stefan Podkowinski > Assignee: Stefan Podkowinski > Priority: Major > > The current CircleCI config could use some cleanup and improvements. First of > all, the config has been made more modular by using the new CircleCI 2.1 > executors and command elements. Based on CASSANDRA-14713, there's now also a > Java 11 executor that will allow running tests under Java 11. The {{build}} > step will be done using Java 11 in all cases, so we can catch any regressions > for that and also test the Java 11 multi-jar artifact during dtests, that > we'd also create during the release process. > The job workflow has now also been changed to make use of the [manual job > approval|https://circleci.com/docs/2.0/workflows/#holding-a-workflow-for-a-manual-approval] > feature, which now allows running dtest jobs only on request and not > automatically with every commit. The Java8 unit tests still do, but that > could also be easily changed if needed. See [example > workflow|https://circleci.com/workflow-run/be25579d-3cbb-4258-9e19-b1f571873850] > with start_ jobs being triggers needed manual approval for starting the > actual jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org