[
https://issues.apache.org/jira/browse/CASSANDRA-14974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747977#comment-16747977
]
Alex Petrov commented on CASSANDRA-14974:
-----------------------------------------
Not sure I should reopen it, but it looks like we might have missed something.
Currently, it looks like we double-wrap subsitute logger which results into:
{code}
INFO [AsyncAppender-Worker-ASYNC] 2019-01-21 14:41:01,193
SubstituteLogger.java:169 - DEBUG [MemtableFlushWriter:1] INSTANCE_127.0.0.3
2019-01-21 14:41:01,193 ColumnFamilyStore.java:1153 - Flushed to
[BigTableReader(path='/private/var/folders/d_/t6f7wkp53g7bf1pcnm69ljwc0000gn/T/dtests8830319164832856679/node3/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/na-2-big-Data.db')]
(1 sstables, 5.155KiB), biggest 5.155KiB, smallest 5.155KiB
INFO [AsyncAppender-Worker-ASYNC] 2019-01-21 14:41:01,196
SubstituteLogger.java:169 - DEBUG [MemtableFlushWriter:1] INSTANCE_127.0.0.2
2019-01-21 14:41:01,196 ColumnFamilyStore.java:1153 - Flushed to
[BigTableReader(path='/private/var/folders/d_/t6f7wkp53g7bf1pcnm69ljwc0000gn/T/dtests8830319164832856679/node2/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/na-2-big-Data.db')]
(1 sstables, 5.155KiB), biggest 5.155KiB, smallest 5.155KiB
INFO [AsyncAppender-Worker-ASYNC] 2019-01-21 14:41:01,226
SubstituteLogger.java:169 - INFO [MigrationStage:1] INSTANCE_127.0.0.2
2019-01-21 14:41:01,226 Keyspace.java:368 - Creating replication strategy
distributed_test_keyspace params KeyspaceParams{durable_writes=true,
replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy,
replication_factor=3}}
{code}
(notice double timestamp, location and log level). If we avoid re-wrapping
substitute logger, this won't happen. We need to fix it either here or in
multi-JVM patch.
> Unit test stdout capture is malfunctioning in 4.0
> -------------------------------------------------
>
> Key: CASSANDRA-14974
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14974
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest, Test/unit
> Reporter: Benedict
> Assignee: Benedict
> Priority: Major
> Fix For: 4.0
>
>
> In 3.x unit tests we make sure to capture stdout to the unit test files, in
> case tests log to stdout and not to a logger. However, in 4.0 due to a
> configuration parameter that is deprecated in logback, the logic is
> short-circuited silently.
> Once fixed, this affects the cleanup of in-jvm dtests which would register an
> infinite chain of System.out overrides (one for each node), so we make the
> functionality robust to multiple instantiations, as well as improve its
> startup/shutdown sequence guarantees.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
