[ https://issues.apache.org/jira/browse/CASSANDRA-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835064#comment-16835064 ]
eBugs commented on CASSANDRA-15118: ----------------------------------- After looking at related code, we found that this {{throw}} statement may make the handling of {{OutOfMemoryError}} ineffective. Specifically, higher up in the call stack, {{BulkLoader.load()}} calls {{JVMStabilityInspector.inspectThrowable()}} to handle {{OutOfMemoryError}}. But since the {{throw}} statement in the description does not wrap the {{OutOfMemoryError}}, {{inspectThrowable()}} will not find out that the actual cause is an {{OutOfMemoryError}}. So, the related code will not execute (lines 59-80 in JVMStabilityInspector.java). Please let me know if we missed something. > OffHeapBitSet() throws a RuntimeException when it runs out of memory > -------------------------------------------------------------------- > > Key: CASSANDRA-15118 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15118 > Project: Cassandra > Issue Type: Bug > Reporter: eBugs > Priority: Normal > > Dear Cassandra developers, we are developing a tool to detect > exception-related bugs in Java. Our prototype has spotted the following > {{throw}} statement whose exception class and error message indicate > different error conditions. > > Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e) > File: > CASSANDRA-ROOT/src/java/org/apache/cassandra/utils/obs/OffHeapBitSet.java > Line: 49 > {code:java} > try > { > long byteCount = wordCount * 8L; > bytes = Memory.allocate(byteCount); > } > catch (OutOfMemoryError e) > { > throw new RuntimeException("Out of native memory occured, You can avoid > it by increasing the system ram space or by increasing > bloom_filter_fp_chance."); > }{code} > > {{RuntimeException}} is usually used to represent errors in the program logic > (think of one of its subclasses, {{NullPointerException}}), while the error > message indicates that {{OffHeapBitSet()}} ran out of memory. This mismatch > could be a problem. For example, the callers may miss the possibility that > {{OffHeapBitSet()}} can run out of memory. Or, the callers trying to handle > other {{RuntimeException}} may accidentally (and incorrectly) handle the out > of memory scenario. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org