[ 
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052316#comment-17052316
 ] 

Aleksey Yeschenko commented on CASSANDRA-15557:
-----------------------------------------------

In 4.0 we get the timestamp from {{FBUtilities.timestampMicros()}} unless it's 
been set explicitly by the user, so yes, the test can be racy as it used to be 
before CASSANDRA-12997. Sylvain's explanation why in the first comment is still 
the most likely one. We derive {{timestampMicros()}} from 
{{System.currentTimeMillis()}}, and that *can* walk back between the two 
statements' executions.

Now, it's tricker to reimplement the same logic in 4.0, so going for the second 
option of explicit timestamp would be my preferred way to resolve this issue.

> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest 
> testDropListAndAddListWithSameName
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: Ryan Svihla
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 
> (mycollection of type list<text>), expected <null> but got <[first element]>
>       at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
>       at 
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to