[ 
https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133825#comment-17133825
 ] 

Alex Deparvu commented on CASSANDRA-14888:
------------------------------------------

[~maedhroz] created a PR https://github.com/apache/cassandra/pull/629

bq. Just heads up...there also may have been an issue (which is now resolved) 
w/ compiling trunk at the time you rebased.
that explains it :)

I rebased the PR, followed your suggestions on the Keyspace metrics it's now 
very close to the Table metrics version.
Re. MV test I added a test but it's not complete, it doesn't seem to create 
those specific metrics, I'm not sure if I missed something.

> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14888
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Ariel Weisberg
>            Assignee: Alex Deparvu
>            Priority: Urgent
>              Labels: patch-available
>             Fix For: 4.0-beta
>
>         Attachments: CASSANDRA-14888.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests, 
> ShortReadProtectionRequests, AntiCompactionTime, BytesValidated, 
> PartitionsValidated, RepairPrepareTime, RepairSyncTime, 
> RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime, 
> WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the 
> entire thing is kind of obscure. Fix it and also add a dtest that detects if 
> any mbeans are left behind after dropping a table and keyspace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to