[
https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133882#comment-17133882
]
Alex Deparvu commented on CASSANDRA-14888:
------------------------------------------
thanks for the review so far.
the last pending issue I guess is related to the MV test itself. as suggested I
moved the test over but I still don't see any of the metrics I was looking for
(from ViewWriteMetrics): ViewReplicasAttempted, ViewReplicasSuccess,
ViewWriteLatency, ViewPendingMutations.
This is what is created during the current test,(and all of this gets correctly
cleaned):
{code}
org.apache.cassandra.metrics.Table.AdditionalWriteLatencyNanos.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.AdditionalWrites.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.AllMemtablesHeapSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.AllMemtablesLiveDataSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.AllMemtablesOffHeapSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.AnticompactionTime.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BloomFilterDiskSpaceUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BloomFilterFalsePositives.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BloomFilterFalseRatio.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BloomFilterOffHeapMemoryUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesAnticompacted.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesFlushed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesMutatedAnticompaction.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesPendingRepair.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesRepaired.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesUnrepaired.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.BytesValidated.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasCommitLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasCommitTotalLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasPrepareLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasPrepareTotalLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasProposeLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CasProposeTotalLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ColUpdateTimeDeltaHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CompactionBytesWritten.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CompressionMetadataOffHeapMemoryUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CompressionRatio.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CoordinatorReadLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CoordinatorScanLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.CoordinatorWriteLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.DroppedMutations.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.EstimatedColumnCountHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.EstimatedPartitionCount.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.EstimatedPartitionSizeHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.IndexSummaryOffHeapMemoryUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.KeyCacheHitRate.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.LiveDiskSpaceUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.LiveSSTableCount.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.LiveScannedHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MaxPartitionSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MeanPartitionSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MemtableColumnsCount.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MemtableLiveDataSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MemtableOffHeapSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MemtableOnHeapSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MemtableSwitchCount.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MinPartitionSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.MutatedAnticompactionGauge.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.OldVersionSSTableCount.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.PartitionsValidated.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.PendingCompactions.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.PendingFlushes.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.PercentRepaired.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RangeLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RangeTotalLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ReadLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ReadRepairRequests.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ReadTotalLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RecentBloomFilterFalsePositives.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RecentBloomFilterFalseRatio.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairJobsCompleted.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairJobsStarted.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairedDataInconsistenciesConfirmed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairedDataInconsistenciesUnconfirmed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairedDataTrackingOverreadRows.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RepairedDataTrackingOverreadTime.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ReplicaSideFilteringProtectionRequests.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RowCacheHit.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RowCacheHitOutOfRange.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.RowCacheMiss.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SSTablesPerReadHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ShortReadProtectionRequests.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SnapshotsSize.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SpeculativeFailedRetries.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SpeculativeInsufficientReplicas.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SpeculativeRetries.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SpeculativeSampleLatencyNanos.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.SyncTime.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.TombstoneFailures.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.TombstoneScannedHistogram.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.TombstoneWarnings.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.TotalDiskSpaceUsed.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.UnleveledSSTables.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.ValidationTime.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.WaitingOnFreeMemtableSpace.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.WriteLatency.junit.tablemetricstest_materialized_view_cleanup,
org.apache.cassandra.metrics.Table.WriteTotalLatency.junit.tablemetricstest_materialized_view_cleanup
{code}
> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-14888
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Ariel Weisberg
> Assignee: Alex Deparvu
> Priority: Urgent
> Labels: patch-available
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Attachments: CASSANDRA-14888.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests,
> ShortReadProtectionRequests, AntiCompactionTime, BytesValidated,
> PartitionsValidated, RepairPrepareTime, RepairSyncTime,
> RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime,
> WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the
> entire thing is kind of obscure. Fix it and also add a dtest that detects if
> any mbeans are left behind after dropping a table and keyspace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
