[
https://issues.apache.org/jira/browse/CASSANDRA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149586#comment-17149586
]
Caleb Rackliffe edited comment on CASSANDRA-15900 at 7/1/20, 5:41 PM:
----------------------------------------------------------------------
I pinged [~bryncooke] about
{{pushed_notifications_test.TestPushedNotifications}}. It's possible
CASSANDRA-15886 actually wasn't a duplicate of CASSANDRA-15677?
[~jasonstack] Unless those last two fail locally or have errors relating to
channel closure, I wouldn't guess they have anything to do with this patch.
However, I'm also not seeing any existing flaky test Jiras for them (closest
are CASSANDRA-15543 and CASSANDRA-15517), so we may need a couple new Jiras.
{{SimpleReadWriteTest}} looks like it got taken out by the forked VM existing
abnormally though.
was (Author: maedhroz):
I pinged [~bryncooke] about
{{pushed_notifications_test.TestPushedNotifications}}. It's possible
CASSANDRA-15886 actually wasn't a duplicate of CASSANDRA-15677?
[~jasonstack] Unless those last two fail locally or have errors relating to
channel closure, I wouldn't guess they have anything to do with this patch.
However, I'm also not seeing any existing flaky test Jiras for them (closest
are CASSANDRA-15543 and CASSANDRA-15517), so we may need a couple new Jiras :/
> Close channel and reduce buffer allocation during entire sstable streaming
> with SSL
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-15900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
> Reporter: ZhaoYang
> Assignee: ZhaoYang
> Priority: Normal
> Fix For: 4.0-beta
>
>
> CASSANDRA-15740 added the ability to stream entire sstable by loading on-disk
> file into user-space off-heap buffer when SSL is enabled, because netty
> doesn't support zero-copy with SSL.
> But there are two issues:
> # file channel is not closed.
> # 1mb batch size is used. 1mb exceeds buffer pool's max allocation size,
> thus it's all allocated outside the pool and will cause large amount of
> allocations.
> [Patch|https://github.com/apache/cassandra/pull/651]:
> # close file channel when the last batch is loaded into off-heap bytebuffer.
> I don't think we need to wait until buffer is flushed by netty.
> # reduce the batch to 64kb which is more buffer pool friendly when streaming
> entire sstable with SSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
