[ https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149642#comment-17149642 ]
Stephen Mallette commented on CASSANDRA-15909: ---------------------------------------------- I suppose that means we deprecate the old names and simply add the consistent names in their place. It seems that can be done without too much trouble - it's just like adding an alias to an existing metric. I can document the names as deprecated in the {{metrics.rst}} file (but would likely just do that as a single documentation task on CASSANDRA-15821). If there is some other method of not "breaking the old names" please let me know or if there is another form of "deprecation" I should consider beyond what is described I'd be happy to hear. Otherwise, I've mostly implemented the approach I've described and should have a something for review shortly. > Make Table/Keyspace Metric Names Consistent With Each Other > ----------------------------------------------------------- > > Key: CASSANDRA-15909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15909 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics > Reporter: Stephen Mallette > Assignee: Stephen Mallette > Priority: Normal > Fix For: 4.0-beta > > > As part of CASSANDRA-15821 it became apparent that certain metric names found > in keyspace and tables had different names but were in fact the same metric - > they are as follows: > * Table.SyncTime == Keyspace.RepairSyncTime > * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows > * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime > * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize > * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize > * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize > * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize > Also, client metrics are the only metrics to start with a lower case letter. > Change those to upper case to match all the other metrics. > Unifying this naming would help make metrics more consistent as part of > CASSANDRA-15582 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org