[ https://issues.apache.org/jira/browse/CASSANDRA-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190326#comment-17190326 ]
Sam Tunnicliffe edited comment on CASSANDRA-14801 at 9/3/20, 5:39 PM: ---------------------------------------------------------------------- Thanks [~Gerrrr], looks good as far as I'm concerned. I've pulled in your patch and I'm happy to commit pending CI and a second +1. ||branch||Circle|| |[14801-trunk|https://github.com/beobal/cassandra/tree/14801-trunk]|[circle|https://app.circleci.com/pipelines/github/beobal/cassandra?branch=14801-trunk]| was (Author: beobal): Thanks [~Gerrrr], looks good as far as I'm concerned. I've pulled in your patch and I'm happy to commit pending CI and a second +1. > calculatePendingRanges no longer safe for multiple adjacent range movements > --------------------------------------------------------------------------- > > Key: CASSANDRA-14801 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14801 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Coordination, Legacy/Distributed Metadata > Reporter: Benedict Elliott Smith > Assignee: Aleksandr Sorokoumov > Priority: Normal > Labels: pull-request-available > Fix For: 4.0, 4.0-beta > > Time Spent: 10m > Remaining Estimate: 0h > > Correctness depended upon the narrowing to a {{Set<InetAddressAndport>}}, > which we no longer do - we maintain a collection of all {{Replica}}. Our > {{RangesAtEndpoint}} collection built by {{getPendingRanges}} can as a result > contain the same endpoint multiple times; and our {{EndpointsForToken}} > obtained by {{TokenMetadata.pendingEndpointsFor}} may fail to be constructed, > resulting in cluster-wide failures for writes to the affected token ranges > for the duration of the range movement. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org