[ 
https://issues.apache.org/jira/browse/CASSANDRA-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223935#comment-17223935
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16235:
-------------------------------------------------

We rely on the directory structure to find the keyspace and table of a sstable. 
We should record those in a component (new or existing) and use that instead of 
relying on any particular directory structure. Doing so isn't trivial and 
probably only reasonable for alpha version.
At this moment it's better to try to work-around this. Typically, we could have 
special code that (only in the sstableloader code tbc), if the normal path 
fails to find a table from a sstable file, look if the top-level directory is 
called "backup" and tries to correct for this. It's a hack so we should open a 
follow up ticket to rework this in the future.
[4.0 pull request | https://github.com/ekaterinadimitrova2/cassandra/pull/68] | 
[CI Java 8 | 
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/454/workflows/5dbb8e75-9741-4231-b7b8-016e2368f18d]
 | [CI Java 11 | 
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/454/workflows/5ad44fd2-6a93-4f7b-a7ac-98839a2d1093]

Only failed test in Java 11 and unrelated - test_compression_cql_options - 
compression_test.TestCompression; I will check on Monday whether a ticket is 
needed for it

[~brandon.williams], do you mind to review this one, please, if you have some 
time?
Thanks in advance!

> SSTableLoader issue when restoring a table named backups
> --------------------------------------------------------
>
>                 Key: CASSANDRA-16235
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16235
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/sstable
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> "backups" is a keyword used to parse sstable path 
> (Descriptor.fromFilename())..
> If sstable file's parent directory name is "backups", it takes "backups"'s 
> parent directory name as table name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to