[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486262#comment-17486262
]
Berenguer Blasi commented on CASSANDRA-16956:
---------------------------------------------
Hi Stefan:
- Looks like CI for j11 is missing? Also CI for j11 under j8. And given it's
such an overreaching change I would run upgrade tests in this occasion.
- I would add a note to NEWS.txt?
- {{LogbackStatusListener}} could be removed the Win newline detection logic
- Docs refactoring has finished now. [~mck] Can we address removing references
to Win in the docs now or better wait the adocs have been brought up to date?
- Iirc it was requested code comments to be rephrased to remove references to
Windows as well?
^ These are what I noticed. But lets see what other reviewers think. I think
we're almost there.
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc, signature.asc, signature.asc, signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
