[ https://issues.apache.org/jira/browse/CASSANDRA-17543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521649#comment-17521649 ]
Andres de la Peña edited comment on CASSANDRA-17543 at 4/13/22 12:34 PM: ------------------------------------------------------------------------- [~maedhroz] I have extracted that superclass and split the test into its six main groups: * Point * IN * Range * Slice * Unrestricted * Collection ||PR||CI|| |[4.0|https://github.com/apache/cassandra/pull/1568]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1475/workflows/5fc242fb-1caa-4628-8462-7eaffdb00884] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1475/workflows/1b84d1f0-636f-4b8d-abcc-91fa6b6eb92f]| |[trunk|https://github.com/apache/cassandra/pull/1569]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1473/workflows/fdd53867-ef49-4b02-9630-f01c8a827c85] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1473/workflows/48511c2a-bf7f-4c4c-9b08-a34dad8d09f8]| Splitting should increase the total cost a bit because of the additional {{Cluster}} initializations, but each of the six classes is at least fourfold faster than the original. I guess we could have had a more even load between splits if we split per parameter combination (maybe flush/page?) instead of per query type, but this way is probably easier to read and each class is more manageable in size. was (Author: adelapena): [~maedhroz] I have extracted that superclass and split the test into its six main groups: * Point * IN * Range * Slice * Unrestricted * Collection ||PR||CI|| |[4.0|https://github.com/apache/cassandra/pull/1568]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1475/workflows/5fc242fb-1caa-4628-8462-7eaffdb00884] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1475/workflows/1b84d1f0-636f-4b8d-abcc-91fa6b6eb92f]| |[trunk|https://github.com/apache/cassandra/pull/1569]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1473/workflows/fdd53867-ef49-4b02-9630-f01c8a827c85] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1473/workflows/48511c2a-bf7f-4c4c-9b08-a34dad8d09f8]| Splitting should increase the total cost a bit because of the additional {{Cluster}} initialization but each of the six classes is at least fourfold faster than the original. I guess we could have had a more even load between splits if we split per parameter combination (maybe flush/page?) instead of per query type, but this way is probably easier to read and each class is more manageable in size. > ReadRepairQueryTypesTest.testUnrestrictedQueryOnSkinnyTable[8: strategy=NONE > coordinator=1 flush=false paging=false] times out sporadically > ------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-17543 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17543 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java > Reporter: Caleb Rackliffe > Assignee: Andres de la Peña > Priority: Normal > Fix For: 4.x > > > org.apache.cassandra.distributed.test.ReadRepairQueryTypesTest.testUnrestrictedQueryOnSkinnyTable[8: > strategy=NONE coordinator=1 flush=false paging=false] > {noformat} > Error Message > Timeout occurred. Please note the time in the report does not reflect the > time until the timeout. > Stacktrace > junit.framework.AssertionFailedError: Timeout occurred. Please note the time > in the report does not reflect the time until the timeout. > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.Vector.forEach(Vector.java:1388) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.Vector.forEach(Vector.java:1388) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.Vector.forEach(Vector.java:1388) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at org.apache.cassandra.anttasks.TestHelper.execute(TestHelper.java:53) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.util.Vector.forEach(Vector.java:1388) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > See > https://ci-cassandra.apache.org/job/Cassandra-trunk/1075/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/testUnrestrictedQueryOnSkinnyTable_8__strategy_NONE_coordinator_1_flush_false_paging_false_/ -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org