[
https://issues.apache.org/jira/browse/CASSANDRA-17062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525983#comment-17525983
]
Sam Tunnicliffe commented on CASSANDRA-17062:
---------------------------------------------
Apologies for the long delay [~azotcsit]...
{quote}I find "conditional MBean attributes" (meaning they can be populated
conditionally or treated differently) to be very confusing. So I think having
different entities for different MBeans (CacheMetrics and
UnweightedCacheMetrics) is smth clearer to the end user. WDYT?
{quote}
Fair enough, I take that point. Thinking about it a bit more, I think my main
issue is this:
I know it's perfectly legal, but I find the hiding of methods by overloading in
the {{UnweightedCacheSize/CacheSize}} and
{{UnweightedCacheMetrics/CacheMetrics}} hierarchies somewhat unintuitive.
I've tried an alternative approach of adding an abstract base class for cache
metrics. This way, the two classes of caches can track and expose the
particular metrics that are relevant to them, capacity & size in bytes for
weighted and max entries & entries for unweighted, without any overloading or
hiding. I've pushed that
[here|https://github.com/beobal/cassandra/tree/samt/17062-trunk-rebase] on top
of a rebase on trunk. A few things had changed in the course of the docs
migration to the {{adoc}} format, plus CASSANDRA-16958.
Let me know what you think.
> Expose Auth Caches metrics
> --------------------------
>
> Key: CASSANDRA-17062
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17062
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Observability/Metrics,
> Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Aleksei Zotov
> Priority: Normal
> Fix For: 4.x
>
>
> Unlike to other caches (row, key, counter), Auth Caches lack some monitoring
> capabilities. Here are a few particular changes to get this inequity fixed:
> # Add auth caches to _system_views.caches_ VT
> # Expose auth caches metrics via JMX
> # Add auth caches details to _nodetool info_
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
