[
https://issues.apache.org/jira/browse/CASSANDRA-17643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543898#comment-17543898
]
Andres de la Peña edited comment on CASSANDRA-17643 at 5/30/22 12:10 PM:
-------------------------------------------------------------------------
It seems that this has removed the approval step for
{{utests_system_keyspace_directory}} for both pre-commit and separate
workflows. I think that the separate workflow should keep the approval step.
Otherwise, running any specific job in the separate workflow would force us to
needlessly run the entire {{utests_system_keyspace_directory}} job. That
happens for example in [this
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1636/workflows/10ddbf30-bfbe-4517-a3e2-5656f49c700d],
which just tries to reproduces a flaky.
was (Author: adelapena):
It seems that this has removed the approval step for
{{utests_system_keyspace_directory}} for both pre-commit and separate
workflows. I think that the separate workflow should keep the approval step.
Otherwise, running any specific job in the separate workflow would force us
would force us to needlessly run the entire
{{utests_system_keyspace_directory}} job. That happens for example in [this
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1636/workflows/10ddbf30-bfbe-4517-a3e2-5656f49c700d],
which just tries to reproduces a flaky.
> Add utests_system_keyspace_directory to pre-commit tests workflow in CircleCI
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-17643
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17643
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: High
> Fix For: 4.0.5, 4.1-beta
>
>
> utests_system_keyspace_directory tests get broken every now and then but we
> don't have them added in Jenkins and they are not mandatory pre-commit in
> CircleCI.
> A quick first step to have a better monitoring on those is to add them at
> least being mandatory ran before a commit in CircleCI
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
