[ 
https://issues.apache.org/jira/browse/CASSANDRA-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545610#comment-17545610
 ] 

David Capwell commented on CASSANDRA-17244:
-------------------------------------------

{code}
public List<String> getWarnings()
    {
        State state = get();
        if (state == null || state.warnings.isEmpty())
            return null;
        return state.warnings;
    }
{code}

so state is null or no warnings we get a null, which is unexpected in this 
case... we do know we hit TombstoneAbortException (else we would has 
AssertionError), so we know 

{code}
tombstones.aborts.instances.isEmpty() == false
{code}

so 
org.apache.cassandra.service.reads.thresholds.CoordinatorWarnings#recordAborts 
should add this warning

{code}
String msg = toString.apply(counter.aborts.instances.size(), 
counter.aborts.maxValue, cql);
ClientWarn.instance.warn(msg + " with " + loggableTokens);
{code}

which we should be able to see in logs... will try to see if any builds exist 
still with logs to confirm

> Fix 
> org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17244
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17244
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition
>  failed 
> [here|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1354/testReport/junit/org.apache.cassandra.distributed.test.trackwarnings/TombstoneCountWarningTest/failThresholdSinglePartition/]
> I didn't find any other occurrences but seems to me legit failure.
> CC [~dcapwell] as I think you were working on those and probably you will 
> make better assessment than me. :) 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to